check for custom gulp setting before using global #8851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should fix #7839. |
scott-lin
reviewed
Nov 15, 2018
scott-lin
reviewed
Nov 15, 2018
scott-lin
reviewed
Nov 15, 2018
moswald
force-pushed
the
users/maoswald/fixGulpPath
branch
from
95c3832 to
3c82c41
Compare
stephenmichaelf
approved these changes
Nov 16, 2018
|
@scott-lin I've bumped to 1.0, if you want to do a quick review. @TingluoHuang, same comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Gulp task lets the user set a custom gulp.js location, but only checks for it if the global gulp can't be found. This addresses that by checking the user's location first.