Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Task] Azure App Service Deploy - Windows / Linux #8772

Merged
merged 10 commits into from
Nov 26, 2018
Merged

[New Task] Azure App Service Deploy - Windows / Linux #8772

merged 10 commits into from
Nov 26, 2018

Conversation

SumiranAgg
Copy link
Contributor

No description provided.

@SumiranAgg SumiranAgg added Area: Release Area: AzureAppService Label to monitor Azure App Service issues labels Nov 2, 2018
@vincent1173 vincent1173 changed the title Azure web app task [New Task] Azure App Service Deploy - Windows / Linux Nov 13, 2018
vincent1173
vincent1173 reviewed Nov 23, 2018
View reviewed changes
Tasks/AzureWebAppDeployment/task.json Outdated Show resolved Hide resolved
Tasks/AzureWebAppDeployment/task.json Outdated Show resolved Hide resolved
Tasks/Common/AzureRmDeploy-common/typings.json Outdated Show resolved Hide resolved
Tasks/AzureWebAppDeployment/README.md Outdated Show resolved Hide resolved
Tasks/Common/AzureRmDeploy-common/azure-arm-rest/webRequestUtility.ts Outdated Show resolved Hide resolved
Tasks/AzureWebAppDeployment/task.json Outdated Show resolved Hide resolved
Tasks/AzureWebAppDeployment/README.md Outdated Show resolved Hide resolved
vincent1173
vincent1173 approved these changes Nov 23, 2018
View reviewed changes
Copy link
Contributor

@vincent1173 vincent1173 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove typings and add them in package.json

  • Please check node module versions are in sync with existing task.

@SumiranAgg SumiranAgg merged commit 43e7dcb into master Nov 26, 2018
@SumiranAgg SumiranAgg deleted the users/suaggar/webApp branch November 26, 2018 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincent1173 vincent1173 vincent1173 approved these changes

@kmkumaran kmkumaran Awaiting requested review from kmkumaran

Assignees
No one assigned
Labels
Area: AzureAppService Label to monitor Azure App Service issues Area: Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SumiranAgg @vincent1173 @suaggar