Fix maven legacy tests to run #8712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhurig
commented
Oct 26, 2018
|
@stephenmichaelf this looks like a general problem since adding V_ to the folder names. I think the testSpec.js script that gets generated may not be noticing the error that should come out for suites that never run. |
brcrista
approved these changes
Oct 26, 2018
madhurig
force-pushed
the
users/madhurig/maventests
branch
from
9f4371c to
6a42149
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the MavenV2 folder was created, the legacy tests stopped running since they were pointing to Maven folder, but there were no errors. Updating them to point to MavenV3 folder and fixing some failures.