Fix for install ssh key task #8283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashtagchris
approved these changes
Sep 10, 2018
madhurig
approved these changes
Sep 10, 2018
|
Please hold on this until my PR, #8274, gets through. |
brcrista
reviewed
Sep 20, 2018
| @@ -52,4 +52,19 @@ describe('InstallSSHKey Suite', function () { | |||
|
|
|||
| done(); | |||
| }); | |||
|
|
|||
| it('SSH key uninstalled from running agent', (done: MochaDone) => { | |||
There was a problem hiding this comment.
These need to be function () for the correct this context to be captured.
Also, you don't need to pass done. That's just for testing async callbacks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a narrow fix that will only happen for private agents. If they install an ssh key on a machine that is already running ssh-agent, then the uninstall would only work if 'ssh-add' was in the path.