No temp nuget.config when NuGet 4.8 or higher #7997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satbai
force-pushed
the
users/satbai/externalEndpointJson
branch
from
2666827 to
959db5c
Compare
satbai
commented
Aug 9, 2018
| @@ -30,6 +37,7 @@ function prepareNuGetExeEnvironment( | |||
| let env: EnvironmentDictionary = {}; | |||
| let originalCredProviderPath: string = null; | |||
| let envVarCredProviderPathV2: string = null; | |||
| let noTempConfigFile: string = null; | |||
satbai
commented
Aug 9, 2018
|
|
||
| const externalCredentials: string = JSON.stringify(enpointCredentialsJson); | ||
| return externalCredentials; | ||
| } |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
satbai
commented
Aug 9, 2018
Tasks/NuGetCommandV2/nugetrestore.ts
Outdated
| @@ -163,19 +170,30 @@ export async function run(nuGetPath: string): Promise<void> { | |||
| } | |||
| } | |||
|
|
|||
| // Setting creds in the temp NuGet.config if needed | |||
| await nuGetConfigHelper.setAuthForSourcesInTempNuGetConfigAsync(); | |||
| tl.debug('nuGetConfigPath'); // satus debugging | |||
satbai
commented
Aug 9, 2018
| env["VSS_NUGET_URI_PREFIXES"] = authInfo.internalAuthInfo.uriPrefixes.join(";") | ||
| } | ||
|
|
||
| let externalCredentials = buildCredentialJson(authInfo); |
There was a problem hiding this comment.
move this inside the V2 cred provider check
aldoms
reviewed
Aug 9, 2018
Tasks/NuGetCommandV2/nugetrestore.ts
Outdated
| await nuGetConfigHelper.setAuthForSourcesInTempNuGetConfigAsync(); | ||
| tl.debug('Setting nuget.config auth'); | ||
| } else { | ||
| tl.debug('Not setting temp nuget.config auth'); |
There was a problem hiding this comment.
nit: add a message saying the new provider will handle auth, or something similar. So we know why we're not adding it.
aldoms
approved these changes
Aug 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.