Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run system information for test run creation #7866

Merged
merged 3 commits into from
Aug 2, 2018

Conversation

prawalagarwal
Copy link
Member

@prawalagarwal prawalagarwal commented Jul 30, 2018

The ability to distinguish in the telemetry the source from which a test run originated is recently added. This is a reactionary work to determine the source as dotnet task and to differentiate it from vstest and publishtest results tasks.

Please refer https://mseng.visualstudio.com/VSOnline/_workitems/edit/1288284 for the string value as suggested by Prachi for RunSystem generated from dotnet task

@nigurr
Copy link

nigurr commented Jul 30, 2018

@prawalagarwal fix the test please

const tl = require('vsts-task-lib/mock-task');
const tlClone = Object.assign({}, tl);
tlClone.getVariable = function(variable: string) {
if (variable == "Agent.TempDirectory")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

case insensitive check

const tlClone = Object.assign({}, tl);
tlClone.getVariable = function(variable: string) {
console.log(`Called for ${variable}`);
if (variable == "Agent.TempDirectory")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@prawalagarwal prawalagarwal merged commit 737c2b3 into master Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants