Using service definition to obtain symbol service url #7822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I confirm the new version of the task did not regress existing behavior on our 3 test builds |
|
We'll have to deploy it to the organization where we have the repro to confirm new behavior works |
|
And the test failures about Npm are unrelated |
sprendermsft
approved these changes
Jul 25, 2018
sprendermsft
reviewed
Aug 2, 2018
| @@ -36,7 +36,7 @@ function Get-SymbolServiceUri ([string]$collectionUri) | |||
| Write-Host "Retrieved artifact service url: '$artifactsUri'" | |||
| } | |||
| else { # Fallback | |||
| if ( [RegEx]::Match($collectionUri, '\.(visualstudio\.com|vsts\.me)') ) { | |||
| if ( [RegEx]::Match($collectionUri, '\.(visualstudio\.com|vsts\.me)').Success ) { | |||
arunkm
added a commit
that referenced
this pull request
Aug 7, 2018
* Using service definition to obtain symbol service url * Fixing Regex result
arunkm
added a commit
that referenced
this pull request
Aug 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.