refactored everything #7736
Merged
refactored everything #7736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acesiddhu
reviewed
Jul 16, 2018
| "required": true, | ||
| "groupName": "packageSettings", | ||
| "helpMarkDown": "ms-resource:loc.input.help.customFeed", | ||
| "visibleRule": "packageFeedSelector = customFeed" |
There was a problem hiding this comment.
visibleRule [](start = 7, length = 11)
hide the new inputs
acesiddhu
reviewed
Jul 16, 2018
|
|
||
| if (resultCode !== 0) { | ||
| tl.error(tl.loc('NugetErrorCode', resultCode)); | ||
| throw new Error(`Download failed with error code: ${resultCode}.`); |
There was a problem hiding this comment.
Download failed with error code [](start = 29, length = 31)
localized
acesiddhu
reviewed
Jul 16, 2018
|
|
||
| if (resultCode !== 0) { | ||
| tl.error(tl.loc('NugetErrorCode', resultCode)); | ||
| throw new Error(`Download failed with error code: ${resultCode}.`); |
There was a problem hiding this comment.
Download failed with error code [](start = 29, length = 31)
localized
acesiddhu
reviewed
Jul 16, 2018
| import { async } from 'q'; | ||
|
|
||
| export class NugetFeedInstaller { | ||
| public consolidatedCiData: { [key: string]: string; } = <{ [key: string]: string; }>{}; |
There was a problem hiding this comment.
public [](start = 4, length = 6)
private
ShreyasRmsft
deleted the
users/ShreyasRMsft/offlineSupportForVsTestToolInstaller
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactored everything in preparation for adding offline support