-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Users/mizho/dropplugins #7610
Users/mizho/dropplugins #7610
Conversation
Tasks/Checkout/task.json
Outdated
@@ -0,0 +1,40 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this file, this is an example for you, not for final check-in :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
Tasks/DownloadBuildDropV0/task.json
Outdated
"Patch": 0 | ||
}, | ||
"groups": [], | ||
"demands": [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need demand min agent version for your new tasks to prevent your task landed on an agent that doesn't have your plugin implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it something like this?
"minimumAgentVersion": "1.91.0",
But what version should I use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might want to target next agent release. do 2.138.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
Tasks/DownloadBuildDropV0/task.json
Outdated
"name": "targetpath", | ||
"type": "filePath", | ||
"label": "Path to download to", | ||
"defaultValue": "$(Build.DropDownloadingDirectory)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why default to this variable? is this a predefined variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
Tasks/DownloadBuildDropV0/task.json
Outdated
"name": "DownloadBuildDrop", | ||
"friendlyName": "Download Build Drop", | ||
"description": "Download Build Drop", | ||
"helpMarkDown": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might want to fill out helpMarkDown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@@ -0,0 +1,48 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mark this task as preview
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@@ -0,0 +1,42 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mark as preview
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Tasks/PublishBuildDropV0/task.json
Outdated
"name": "PublishBuildDrop", | ||
"friendlyName": "Publish Build Drop", | ||
"description": "Publish Build Drop", | ||
"helpMarkDown": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might want to fill out helpMarkDown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
Tasks/PublishBuildDropV0/task.json
Outdated
"Patch": 0 | ||
}, | ||
"groups": [], | ||
"demands": [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
min agent version demands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Tasks/PublishBuildDropV0/task.json
Outdated
"name": "artifactname", | ||
"type": "string", | ||
"label": "The name of this artifact", | ||
"defaultValue": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i thought we have a default artifact name "drop" today, do we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
Tasks/PublishBuildDropV0/task.json
Outdated
"name": "targetpath", | ||
"type": "filePath", | ||
"label": "Path to publish", | ||
"defaultValue": "$(Build.DropStagingDirectory)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this variable exist? who populate it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
I am good with the task.json changes, double check with your PM make sure the input are right. |
No description provided.