Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to fix vulnerabilities #7289

Merged
merged 3 commits into from
May 25, 2018
Merged

Updated to fix vulnerabilities #7289

merged 3 commits into from
May 25, 2018

Conversation

lkillgore
Copy link
Contributor

No description provided.

@lkillgore lkillgore closed this May 24, 2018
@lkillgore lkillgore reopened this May 24, 2018
@lkillgore lkillgore requested a review from stephenmichaelf May 25, 2018 12:25
@@ -19,6 +19,6 @@
"dependencies": {
"vsts-task-lib": "2.0.5",
"jszip": "^3.1.2",
"request": "2.72.0"
"request": "2.87.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't bump the version number, Agents won't download the new version of the task.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! embarrassed emoji

Copy link
Member

@jpricket jpricket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment

@AlexRukhlin AlexRukhlin requested review from AlexRukhlin and removed request for AlexRukhlin May 25, 2018 13:33
Copy link
Contributor

@AlexRukhlin AlexRukhlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe, you shouldn't commit package-lock files.

@AlexRukhlin AlexRukhlin dismissed their stale review May 25, 2018 13:54

A wrong assertion. Sorry.

@lkillgore lkillgore merged commit feebd93 into master May 25, 2018
@lkillgore lkillgore deleted the users/lukillgo/1268139 branch May 25, 2018 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants