Multiple fixes to the CLT tasks (QuickPerfTestV1|RunLoadTestV1|RunJMeterLoadTestV1) #7226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganesp
changed the title
cltshivash
reviewed
May 17, 2018
| $tdjson = @" | ||
| { | ||
| "dropType": "InplaceDrop", | ||
| "dropType": "TestServiceBlobDrop", |
There was a problem hiding this comment.
TestServiceBlobDrop [](start = 21, length = 19)
why is there a change in the drop type ?
There was a problem hiding this comment.
For Jmeter it was always TestServiceBlobDrop.
This particular function was unused.
I am using it now, hence the change in the dropType here.
acesiddhu
approved these changes
May 18, 2018
| "East US": "East US (Virginia)", | ||
| "East US 2": "East US 2 (Virginia)", | ||
| "Australia East": "Australia East (New South Wales)", | ||
| "Australia Southeast": "Australia Southeast (Victoria)", |
There was a problem hiding this comment.
did u do upgrade testing. not sure if existing build definition will break
There was a problem hiding this comment.
Yes, validated the upgrade path as well.
acesiddhu
dismissed
cltshivash’s stale review
he is oof. and he has already reviewed ofline
ganesp
added a commit
that referenced
this pull request
May 18, 2018
…terLoadTestV1) (#7226) Fixes: 1) Fixed a new domain issue with the quick web test task Removed a check for hosted account where we were using hard coded URLs. We are not doing any validation for hosted now – which is the case with other two tasks already. 2) Fixed an issue with the default values for self-provisioned rig option Without default values for agent group and agent count the quick web test\load test tasks do fail Defaults values --> agent group = default, number of agents = 1 3) Fixed a broken link issue with the JMeter result link on build summary, markdown fixed It was already fixed for other two tasks earlier Changes: 4) Geo location list for tasks is updated to add India locations –- South India, Central India 5) Added geo location input in the JMeter task –- it was not present earlier 6) The geo location list is now sorted -- it was not sorted earlier
ganesp
added a commit
that referenced
this pull request
May 18, 2018
…terLoadTestV1) (#7226) (#7251) Fixes: 1) Fixed a new domain issue with the quick web test task Removed a check for hosted account where we were using hard coded URLs. We are not doing any validation for hosted now – which is the case with other two tasks already. 2) Fixed an issue with the default values for self-provisioned rig option Without default values for agent group and agent count the quick web test\load test tasks do fail Defaults values --> agent group = default, number of agents = 1 3) Fixed a broken link issue with the JMeter result link on build summary, markdown fixed It was already fixed for other two tasks earlier Changes: 4) Geo location list for tasks is updated to add India locations –- South India, Central India 5) Added geo location input in the JMeter task –- it was not present earlier 6) The geo location list is now sorted -- it was not sorted earlier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Fixed a new domain issue with the quick web test task
Removed a check for hosted account where we were using hard coded URLs.
We are not doing any validation for hosted now – which is the case with other two tasks already.
Fixed an issue with the default values for self-provisioned rig option
Without default values for agent group and agent count the quick web test\load test tasks do fail
Defaults values --> agent group = default, number of agents = 1
Fixed a broken link issue with the JMeter result link on build summary, markdown fixed
It was already fixed for other two tasks earlier
Changes:
Geo location list for tasks is updated to add India locations –- South India, Central India
Added geo location input in the JMeter task –- it was not present earlier
The geo location list is now sorted -- it was not sorted earlier