Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the checked in ios-signing-common definition. #7016

Merged
merged 1 commit into from
Apr 18, 2018

Conversation

hashtagchris
Copy link
Contributor

@hashtagchris hashtagchris commented Apr 17, 2018

Rely on the build to produce the contract. Also move private functions to the end of ios-signing-common.ts.

Testing:

  • Privately bumped the version on InstallAppleCertificate, InstallAppleProvisioningProfile and Xcode, built, tested, tfx'ed and queued a build definition using these three tasks.
  • Tested "Go to Definition" in preinstallcert.ts and xcode.ts.

Rely on the build to produce the contract.
@hashtagchris
Copy link
Contributor Author

If we're good with these changes I'll tackle java-common.d.ts and ssh-common.ts in a separate PR. I think that would take care of CIX's definitions.

Copy link
Contributor

@madhurig madhurig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hashtagchris hashtagchris merged commit 984a93f into master Apr 18, 2018
@hashtagchris hashtagchris deleted the users/htc/remove_manual_definition branch April 18, 2018 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants