SqlAzureDacpacDeployment: Bug fix for firewall Auto-Detect #6613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ajay-MS
reviewed
Mar 7, 2018
| Write-Verbose "Reaching SqlServer to check connection by running Invoke-SqlCmd" | ||
| Write-Verbose "Invoke-Sqlcmd -ServerInstance $serverName -Username $formattedSqlUsername -Password ****** -Query `"select getdate()`" -ErrorVariable errors | Out-String" | ||
|
|
||
| $output = Invoke-Sqlcmd -ServerInstance $serverName -Username $formattedSqlUsername -Password $sqlPassword -Query "select getdate()" -ErrorVariable errors | Out-String |
Ajay-MS
reviewed
Mar 7, 2018
| @@ -250,3 +265,17 @@ function ConvertParamToSqlSupported | |||
| return $param | |||
| } | |||
|
|
|||
| function Test-CommandExists | |||
There was a problem hiding this comment.
Alternatively, you can write this as single condition of if block as if (Get-Command $commandName -ErrorAction SilentlyContinue) {}
Ajay-MS
approved these changes
Mar 7, 2018
asranja
commented
Mar 7, 2018
| ) | ||
|
|
||
| try { | ||
| Get-Command -Name $commandName |
There was a problem hiding this comment.
Add -ErrorAction Stop explicitly as well.
asranja
added a commit
that referenced
this pull request
Mar 14, 2018
* SqlAzureDacpacDeployment: Bug fix for firewall Auto-Detect * Addressing review comments * Added connection timeout for Invoke-Sqlcmd * Added troubleshooting section in README * Updated README
asranja
added a commit
that referenced
this pull request
Mar 14, 2018
…6685) * SqlAzureDacpacDeployment: Bug fix for firewall Auto-Detect (#6613) * SqlAzureDacpacDeployment: Bug fix for firewall Auto-Detect * Addressing review comments * Added connection timeout for Invoke-Sqlcmd * Added troubleshooting section in README * Updated README * Updated troubleshooting link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.