Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AzureRGDeploy] Sanitizing parameters bug fix #6349

Merged
merged 3 commits into from
Feb 2, 2018

Conversation

thesattiraju
Copy link
Contributor

No description provided.

@thesattiraju thesattiraju changed the title [AzureRGDeploy] Sanitization bug fix [AzureRGDeploy] Sanitizing parameters bug fix Feb 2, 2018
Copy link
Member

@amaljg amaljg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments before check-in.

@@ -4,10 +4,14 @@ class Utils {
return (!!str && !!str.trim());
}

public static getError(error: any) {
public static getError(error: any): string {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to take this as part of hotfix?

@thesattiraju thesattiraju merged commit f89fa98 into master Feb 2, 2018
thesattiraju added a commit that referenced this pull request Feb 2, 2018
* [AzureRGDeploy] Sanitization bug fix

* Fixing getError

* Revert "Fixing getError"

This reverts commit 506497e.
thesattiraju added a commit that referenced this pull request Feb 2, 2018
* [AzureRGDeploy] Sanitization bug fix

* Fixing getError

* Revert "Fixing getError"

This reverts commit 506497e.
thesattiraju added a commit that referenced this pull request Feb 2, 2018
* [AzureRGDeploy] Sanitization bug fix

* Fixing getError

* Revert "Fixing getError"

This reverts commit 506497e.
@thesattiraju thesattiraju deleted the users/desattir/AzureRGbugFix branch February 2, 2018 08:00
thesattiraju added a commit that referenced this pull request Feb 2, 2018
* [AzureRGDeploy] Sanitization bug fix

* Fixing getError

* Revert "Fixing getError"

This reverts commit 506497e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants