Allow overriding memory limit on docker build/run #6345
Conversation
| "label": "Memory limit", | ||
| "visibleRule": "action = Build an image || action = Run an image", | ||
| "helpMarkDown": "The maximum amount of memory available to the container as a integer with optional suffixes like '2GB'.", | ||
| "groupName": "advanced" |
There was a problem hiding this comment.
Is your build passing? I think inputs and dependents inputs should be in the same group?.
There was a problem hiding this comment.
Not sure what dependent inputs you're talking about.
There was a problem hiding this comment.
Visibility of 'memory' is dependent on 'action'. While action is in no group 'memory' is in advance group. VSTS task compile fails if both the inputs are in the different groups. I am not sure what will happen if one of the input is in no specified group. If there is no compilation error, its good. I just wanted you to check this.
There was a problem hiding this comment.
I, of course, compiled and ran both the existing and new tests I wrote. This is written like the other task options dependency on action.
There was a problem hiding this comment.
...that said, have you considered build validation via TravisCI, AppVeyor, and/or other? I see you have a .vsts-cj.yml file as well. Is that not configured for PRs? I was surprised to see that there was no PR validation when the environment is fairly self-contained (except for requiring npm 3.x when I had 5.x that does not work for this repo). That would help provide some assurance no one breaks anything and you don't have to rely on manual testing or contributors' word they built and tested...even though I did. :)
Fixes #6342