include extra help to deal with the special handling of the domain ov… #6222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would honestly rather fix the code and not default to a local user, but as the code is so explicit I would prefer some documentation that is easier to access. |
|
Thanks for your contribution. We are currently supporting following formats of username for deployment
Please update your PR to include all these three type. |
elangelo
force-pushed
the
powershellOnTargetMachines
branch
from
43060ef to
1eea647
Compare
|
That is done. Though I must admit that we haven't had much luck with the 'AdminUser@domain' syntax. |
|
Thanks for the update on PR. I will validate these changes and will merge PR within next 2 days. |
|
looks good to me |
Ajay-MS
approved these changes
Jan 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…erride of the login
As I think the way this PowershellOnTargetMachines deals with the domain attribute of the login, it would be good to include it explicitly in the short help text.
(Special in the sense that if you 'normally' start a new remote Powershell Session the fact that the machine is running on a domain pretty much ensures that the user you are using is a domain user. This task specifically overrides this default behavior.)