Delete features moved to the SonarQube extension #6060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
madhurig
reviewed
Dec 18, 2017
Tasks/Gradle/task.json
Outdated
| }, | ||
| { | ||
| "name": "sqGradlePluginVersion", | ||
| "aliases": [ "sonarQubeGradlePluginVersion" ], | ||
| "type": "string", | ||
| "label": "SonarQube Gradle Plugin Version", | ||
| "type": "pickList", |
There was a problem hiding this comment.
PickList seems like a bad idea for version which might change going forward. You can have a radio button for "Use plugin applied in your build.gradle" or "Specify version number" and default the the specific version number to 2.6.1
henryju
force-pushed
the
clean_sonarqube
branch
from
dcd1031 to
50ca2f4
Compare
madhurig
reviewed
Jan 26, 2018
Tasks/Gradle/task.json
Outdated
| "Major": 1, | ||
| "Minor": 128, | ||
| "Major": 2, | ||
| "Minor": 0, |
There was a problem hiding this comment.
Please update minor version to "130"
madhurig
reviewed
Jan 26, 2018
Tasks/Maven/task.json
Outdated
| "Major": 1, | ||
| "Minor": 128, | ||
| "Major": 2, | ||
| "Minor": 0, |
There was a problem hiding this comment.
Please update minor version to 130
henryju
force-pushed
the
clean_sonarqube
branch
from
f3ae9f4 to
7e8827e
Compare
henryju
force-pushed
the
clean_sonarqube
branch
from
7e8827e to
b07777d
Compare
madhurig
reviewed
Jan 29, 2018
Tasks/Gradle/task.json
Outdated
| "required": true, | ||
| "defaultValue": "false", | ||
| "groupName": "CodeAnalysis", | ||
| "helpMarkDown": "Run a [SonarQube analysis](https://go.microsoft.com/fwlink/?LinkID=708598) after executing the current goals. 'install' or 'package' goals should be executed first." | ||
| "helpMarkDown": "Run a [SonarQube or SonarCloud analysis](http://redirect.sonarsource.com/doc/install-configure-scanner-tfs-ts.html) after executing the current tasks. You have to add the `Prepare Analysis Configuration` task of the [SonarQube](https://marketplace.visualstudio.com/items?itemName=SonarSource.sonarqube) or [SonarCloud](https://marketplace.visualstudio.com/items?itemName=SonarSource.sonarcloud) extensions in your build definition before this Gradle task." |
There was a problem hiding this comment.
@davidstaheli : Any feedback/suggestions on this help text?
There was a problem hiding this comment.
Can we please change this as follows to explain how the behavior changed from version 1 of the Gradle task?
This option has changed from version 1 of the **Gradle** task to use the [SonarQube](https://marketplace.visualstudio.com/items?itemName=SonarSource.sonarqube) and [SonarCloud](https://marketplace.visualstudio.com/items?itemName=SonarSource.sonarcloud) marketplace extensions. Enable this option to run [SonarQube or SonarCloud analysis](http://redirect.sonarsource.com/doc/install-configure-scanner-tfs-ts.html) after executing tasks in the **Tasks** field. You must also add a **Prepare Analysis Configuration** task from one of the extensions to the build definition before this Gradle task.
Tasks/Maven/task.json
Outdated
| "required": true, | ||
| "defaultValue": "false", | ||
| "groupName": "CodeAnalysis", | ||
| "helpMarkDown": "Run a [SonarQube analysis](https://go.microsoft.com/fwlink/?LinkID=708598) after executing the current goals. 'install' or 'package' goals should be executed first." | ||
| "helpMarkDown": "Run a [SonarQube or SonarCloud analysis](http://redirect.sonarsource.com/doc/install-configure-scanner-tfs-ts.html) after executing the current goals. `install` or `package` goals should be executed first. You have to add the `Prepare Analysis Configuration` task of the [SonarQube](https://marketplace.visualstudio.com/items?itemName=SonarSource.sonarqube) or [SonarCloud](https://marketplace.visualstudio.com/items?itemName=SonarSource.sonarcloud) extensions in your build definition before this Maven task." |
There was a problem hiding this comment.
Can we please change this as follows to explain how the behavior changed from version 1 of the Maven task?
This option has changed from version 1 of the **Maven** task to use the [SonarQube](https://marketplace.visualstudio.com/items?itemName=SonarSource.sonarqube) and [SonarCloud](https://marketplace.visualstudio.com/items?itemName=SonarSource.sonarcloud) marketplace extensions. Enable this option to run [SonarQube or SonarCloud analysis](http://redirect.sonarsource.com/doc/install-configure-scanner-tfs-ts.html) after executing goals in the **Goals** field. The **install** or **package** goal should run first. You must also add a **Prepare Analysis Configuration** task from one of the extensions to the build definition before this Maven task.
Tasks/Gradle/task.json
Outdated
| "required": true, | ||
| "defaultValue": "false", | ||
| "groupName": "CodeAnalysis", | ||
| "helpMarkDown": "Run a [SonarQube analysis](https://go.microsoft.com/fwlink/?LinkID=708598) after executing the current goals. 'install' or 'package' goals should be executed first." | ||
| "helpMarkDown": "Run a [SonarQube or SonarCloud analysis](http://redirect.sonarsource.com/doc/install-configure-scanner-tfs-ts.html) after executing the current tasks. You have to add the `Prepare Analysis Configuration` task of the [SonarQube](https://marketplace.visualstudio.com/items?itemName=SonarSource.sonarqube) or [SonarCloud](https://marketplace.visualstudio.com/items?itemName=SonarSource.sonarcloud) extensions in your build definition before this Gradle task." |
There was a problem hiding this comment.
Can we please change this as follows to explain how the behavior changed from version 1 of the Gradle task?
This option has changed from version 1 of the **Gradle** task to use the [SonarQube](https://marketplace.visualstudio.com/items?itemName=SonarSource.sonarqube) and [SonarCloud](https://marketplace.visualstudio.com/items?itemName=SonarSource.sonarcloud) marketplace extensions. Enable this option to run [SonarQube or SonarCloud analysis](http://redirect.sonarsource.com/doc/install-configure-scanner-tfs-ts.html) after executing tasks in the **Tasks** field. You must also add a **Prepare Analysis Configuration** task from one of the extensions to the build definition before this Gradle task.
madhurig
approved these changes
Feb 1, 2018
madhurig
pushed a commit
that referenced
this pull request
Feb 5, 2018
* Delete features moved to the SonarQube extension * Use a radio to specify Gradle scanner version * Use a radio to select Maven Scanner version + clean Gradle tests * Remove option to specify Maven Scanner version * Change minor task version to 130 * Improve documentation * Commit files generated during the build * Apply David's feedback
madhurig
pushed a commit
that referenced
this pull request
Feb 5, 2018
* Delete features moved to the SonarQube extension (#6060) * Delete features moved to the SonarQube extension * Use a radio to specify Gradle scanner version * Use a radio to select Maven Scanner version + clean Gradle tests * Remove option to specify Maven Scanner version * Change minor task version to 130 * Improve documentation * Commit files generated during the build * Apply David's feedback * Fix legacy Maven tests to remove legacy SonarQube integration tests (#6343)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is the consequence of the last release of the new SonarQube and SonarCloud VSTS extensions. Configuration of the SonarQube analysis for Maven/Gradle as well as the analysis report publishing in VSTS dashboard are now handled by those extensions.
Support of pull request decoration will come later (probably as a SonarQube server side feature).