Documentation update for Azure Key Vault Task #5037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
degant
commented
Aug 16, 2017
degant
commented
- General Formatting and Code formatting (wherever required)
- Updating Secrets to Secrets + Certificates since Azure KV now provides access policies for both separately
- General Formatting and Code formatting (wherever required) - Updating Secrets to Secrets + Certificates since Azure KV now provides access policies for both separately
|
take or close |
Lovakumar
suggested changes
Nov 21, 2017
Tasks/AzureKeyVault/README.md
Outdated
|
|
||
| ### Parameters of the task: | ||
|
|
||
| The parameters of the task are described below. The parameters listed with a \* are required parameters for the task: | ||
|
|
||
| * **Azure Subscription**\*: Select the service endpoint for the Azure Subscription where the Azure Key vault instance is created. To configure new service endpoint, select the Azure subscription from the list and click 'Authorize'. If your subscription is not listed or if you want to use an existing Service Principal, you can setup an Azure service connection using 'Manage' link. | ||
|
|
||
| Ensure the Azure endpoint has at least Get and List permissions on the vault. You can set these permissions in the Azure portal: | ||
| Open the Settings blade for the vault, choose Access policies, then Add new.In the Add access policy blade, choose Select principal and select the service principal for your client account.In the Add access policy blade, choose Secret permissions and ensure that Get and List are checked (ticked). Choose OK to save the changes. | ||
| Ensure the Azure endpoint has at least Get and List permissions for Secrets and Certificate Management on the vault. You can set these permissions in the Azure portal: Open the Settings blade for the vault, choose Access policies, then Add new. In the Add access policy blade, choose Select principal and select the service principal for your client account. In the Add access policy blade, choose `Secret permissions` and `Certificate permissions` and ensure that Get and List are checked (ticked) for both. Choose OK to save the changes. |
There was a problem hiding this comment.
This task handles only Secrets construct of Azure Key Vault. Azure has introduced Certificates construct recently hence we should not add certificates yet.
Tasks/AzureKeyVault/README.md
Outdated
|
|
||
| ### Parameters of the task: | ||
|
|
||
| The parameters of the task are described below. The parameters listed with a \* are required parameters for the task: | ||
|
|
||
| * **Azure Subscription**\*: Select the service endpoint for the Azure Subscription where the Azure Key vault instance is created. To configure new service endpoint, select the Azure subscription from the list and click 'Authorize'. If your subscription is not listed or if you want to use an existing Service Principal, you can setup an Azure service connection using 'Manage' link. | ||
|
|
||
| Ensure the Azure endpoint has at least Get and List permissions on the vault. You can set these permissions in the Azure portal: | ||
| Open the Settings blade for the vault, choose Access policies, then Add new.In the Add access policy blade, choose Select principal and select the service principal for your client account.In the Add access policy blade, choose Secret permissions and ensure that Get and List are checked (ticked). Choose OK to save the changes. | ||
| Ensure the Azure endpoint has at least Get and List permissions for Secrets and Certificate Management on the vault. You can set these permissions in the Azure portal: Open the Settings blade for the vault, choose Access policies, then Add new. In the Add access policy blade, choose Select principal and select the service principal for your client account. In the Add access policy blade, choose `Secret permissions` and `Certificate permissions` and ensure that Get and List are checked (ticked) for both. Choose OK to save the changes. |
There was a problem hiding this comment.
Remove Certificate permissions
|
@degant, @Lovakumar Can one of you please make the change that lova has requested? |
Lovakumar
approved these changes
Jan 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.