Remove AzureRM instances and add helpMarkDown text. #3286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvvsubbu
reviewed
Dec 21, 2016
| @@ -211,8 +211,8 @@ export async function getAzureRMWebAppConfigDetails(SPN, webAppName: string, res | |||
| deferred.resolve(obj); | |||
| } | |||
| else { | |||
| tl.error(response.statusMessage); | |||
| deferred.reject(tl.loc('UnabletoretrieveAzureRMWebAppConfigDetails', response.statusCode, response.statusMessage)); | |||
| tl.error(body); | |||
There was a problem hiding this comment.
why are we giving complete body ?
There was a problem hiding this comment.
'body' may have some context regarding the error. it will be be a string or just a simple json.
There was a problem hiding this comment.
check the experience how it is looking when you are giving full body.
There was a problem hiding this comment.
changed tl.error(body) to tl.debug(body);
mvvsubbu
reviewed
Dec 21, 2016
| @@ -119,7 +119,7 @@ | |||
| "defaultValue": "false", | |||
| "required": false, | |||
| "groupName": "AdditionalDeploymentOptions", | |||
| "helpMarkDown": "Select the option to take the AzureRM Web App offline by placing an app_offline.htm file in the root directory of the Web App before the sync operation begins. The file will be removed after the sync operation completes successfully." | |||
| "helpMarkDown": "Select the option to take the Azure App service offline by placing an app_offline.htm file in the root directory of the Web App before the sync operation begins. The file will be removed after the sync operation completes successfully." | |||
There was a problem hiding this comment.
I shared Task.json given by Usha please update those changes as well.
mvvsubbu
requested changes
Dec 21, 2016
mvvsubbu
reviewed
Dec 21, 2016
| @@ -23,7 +23,7 @@ | |||
| "loc.input.label.WebAppUri": "App Service URL", | |||
| "loc.input.help.WebAppUri": "Specify a name for the output variable that is generated for the URL of the Azure App Service. The variable can be consumed in subsequent tasks.", | |||
| "loc.input.label.TakeAppOfflineFlag": "Take App Offline", | |||
| "loc.input.help.TakeAppOfflineFlag": "Select the option to take the AzureRM Web App offline by placing an app_offline.htm file in the root directory of the Web App before the sync operation begins. The file will be removed after the sync operation completes successfully.", | |||
| "loc.input.help.TakeAppOfflineFlag": "Select the option to take the Azure App service offline by placing an app_offline.htm file in the root directory of the Web App before the sync operation begins. The file will be removed after the sync operation completes successfully.", | |||
There was a problem hiding this comment.
correct to "directory of the App service"
mvvsubbu
reviewed
Dec 21, 2016
| "loc.messages.UnabletoretrieveAzureRMWebAppConfigDetails": "Error Occurred : [Status Code : '%s']", | ||
| "loc.messages.UnabletoretrieveAzureRMWebAppAppSettings": "Error Occurred : [Status Code : '%s', Error Message: '%s']", | ||
| "loc.messages.UnabletoupdateAzureRMWebAppAppSettings": "Error Occurred : [Status Code : '%s', Error Message: '%s']", | ||
| "loc.messages.Unabletoretrievewebconfigdetails": "Unable to retrieve web config details.[Status Code: '%s', Error Message: '%s']", |
There was a problem hiding this comment.
Use App Service Configuration details.
mvvsubbu
reviewed
Dec 21, 2016
| "loc.messages.UnabletoretrieveAzureRMWebAppAppSettings": "Error Occurred : [Status Code : '%s', Error Message: '%s']", | ||
| "loc.messages.UnabletoupdateAzureRMWebAppAppSettings": "Error Occurred : [Status Code : '%s', Error Message: '%s']", | ||
| "loc.messages.Unabletoretrievewebconfigdetails": "Unable to retrieve web config details.[Status Code: '%s', Error Message: '%s']", | ||
| "loc.messages.Unabletoretrievewebappsettings": "Unable to retrieve web app settings. [Status Code: '%s', Error Message: '%s']", |
mvvsubbu
reviewed
Dec 21, 2016
| @@ -15,7 +15,9 @@ | |||
| "Minor": 0, | |||
| "Patch": 0 | |||
| }, | |||
| "preview": "true", | |||
| "editorHints": { | |||
| "preview": "true" | |||
There was a problem hiding this comment.
merge my changes from master, It is overwrite of previous changes of mine
mvvsubbu
requested changes
Dec 21, 2016
mvvsubbu
approved these changes
Dec 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.