Users/prmutn/specifylocationnode #2465
Conversation
|
Hi @preetsaimutneja, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
| tl.error(tl.loc('VstestNotFound', vsVersion)); | ||
| defer.resolve(1); | ||
| return defer.promise; | ||
| if (vstestLocationMethod == "version") { |
There was a problem hiding this comment.
=== instead of ==
always use toLowercase and compare
There was a problem hiding this comment.
split into multiple functions. not more than 10 lines for function
|
Patch no. in task.json needs to be incremented by 1 |
| vstestLocation = path.join(vsCommon, "..\\IDE\\CommonExtensions\\Microsoft\\TestWindow\\vstest.console.exe"); | ||
| } else if (vstestLocationMethod == "location") { | ||
| try { | ||
| fs.accessSync(vstestLocation); |
There was a problem hiding this comment.
Will fs.accessSync throw error if File Doesn't exist? if yes then file not there and access denied will lead to same error message
There was a problem hiding this comment.
actually. you should use tl.exists() there is already lib function.
|
rest looks good |
| defer.resolve(1); | ||
| return defer.promise; | ||
| if (vstestLocationMethod.toLowerCase() === 'version') { | ||
| let vsCommon = tl.getVariable("VS" + vsVersion + "0COMNTools"); |
|
|
|
merge the conflicts. |
Allow users to specify vstest.console.exe path.