Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webdeployment-common package [Part 2] #20073

Merged

Conversation

aleksandrlevochkin
Copy link
Contributor

Task names:

  • AzureRmWebAppDeploymentV3
  • AzureRmWebAppDeploymentV4
  • AzureWebAppContainerV1
  • AzureWebAppV1

Description: Updated webdeployment-common package to include this change: microsoft/azure-pipelines-tasks-common-packages#334

Documentation changes required: N

Added unit tests: N

Attached related issue: AB#2187393

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@aleksandrlevochkin aleksandrlevochkin marked this pull request as ready for review June 27, 2024 11:04
@aleksandrlevochkin aleksandrlevochkin merged commit a3c0158 into master Jul 9, 2024
11 checks passed
@juss-wes
Copy link

We're starting to see widespread issues with the AzureWebAppContainer@1 task, starting with version 1.242.0 (which appears to be created as of this PR). The error states:

##[error]Error: Failed to fetch App Service '[service name]' details. Error: Could not fetch access token for Azure. Status code: network_error, status message: Network request failed"

Version 1.241.0 works fine. I'm still verifying if we can statically use v1.243.x in Azure DevOps Services, which hopefully may resolve the problem.

@v-schhabra
Copy link
Contributor

Hi @juss-wes
Thanks for reporting the issue.
Could you please share us the failed pipeline logs by enabling system.debug to "true"?

@juss-wes
Copy link

Here are 2 executions - one that worked (with the old version) and the other that failed (with the new). I've obfuscated specific internal information with [DESCRIPTION] in many locations within the files, but should give you the insight you need still.
v1.241.0.txt
v1.242.0.txt

@v-schhabra
Copy link
Contributor

Here are 2 executions - one that worked (with the old version) and the other that failed (with the new). I've obfuscated specific internal information with [DESCRIPTION] in many locations within the files, but should give you the insight you need still. v1.241.0.txt v1.242.0.txt

Hi @juss-wes
I checked the logs it seems like you are getting error related to msal node issue. As multiple cx are having this issue so we have already created PR for the fix and will be deployed to all the rings in couple of days.

@juss-wes
Copy link

That's great, thank you!

@yuhungchun
Copy link

Is there way to force to use the earlier version with AzureRmWebAppDeploymentV4 via YAML? Co-polit suggested to use version, however that didn't work.

@aleksandrlevochkin
Copy link
Contributor Author

Hi @yuhungchun, I think you can specify the full task version, for example like this: - task: AzureRmWebAppDeployment@4.240.2

@RyDoug
Copy link

RyDoug commented Jul 25, 2024

@v-schhabra can you share the PR with that fix here?

@v-schhabra
Copy link
Contributor

Hi @RyDoug
#20170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants