Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide option for user to fail PTR if no results are uploaded #19347

Merged

Conversation

eswarnathprudhivi
Copy link
Contributor

@eswarnathprudhivi eswarnathprudhivi commented Dec 6, 2023

Task name: Publish Test Results V2

Description: To provide an option to the user to fail the task if partial / complete test results are not uploaded

Screenshot 2023-12-13 192551

Documentation changes required: (Y/N)

Added unit tests: (Y/N) : Y

Attached related issue: (Y/N)

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@eswarnathprudhivi eswarnathprudhivi force-pushed the users/eprudhivi/failptronfailuretopublishresults branch 2 times, most recently from a800a8c to ca265ae Compare December 13, 2023 13:43
Copy link

@rasunkar rasunkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added my comments

Tasks/PublishTestResultsV2/publishtestresults.ts Outdated Show resolved Hide resolved
Tasks/PublishTestResultsV2/publishtestresults.ts Outdated Show resolved Hide resolved
Tasks/PublishTestResultsV2/publishtestresults.ts Outdated Show resolved Hide resolved
@eswarnathprudhivi eswarnathprudhivi force-pushed the users/eprudhivi/failptronfailuretopublishresults branch 3 times, most recently from d936028 to e567591 Compare December 15, 2023 13:09
Copy link

@rasunkar rasunkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@eswarnathprudhivi eswarnathprudhivi force-pushed the users/eprudhivi/failptronfailuretopublishresults branch from b25b44d to 0cf2a9d Compare December 15, 2023 13:23
Copy link

@rasunkar rasunkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@eswarnathprudhivi eswarnathprudhivi merged commit ee56363 into master Dec 15, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants