Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UseDotNetV2] Update task to node16 using codegen #18676

Merged
merged 3 commits into from
Jul 24, 2023

Conversation

DmitriiBobreshev
Copy link
Contributor

Task name: UseDotNetV2

Description:

  • replaced package.json with package-lock.json for node16 task
  • added agent-base for node16 version
  • modified make.json to remove it from azure-arm-rest package
  • replaced util.error to Error
  • Fixed test since the handler was incorrect
  • removed duplicate task lib

Documentation changes required: N

**Added unit tests:**Y

Attached related issue: (Y/N)

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

- replaced package.json with package-lock.json for node16 task
- added agent-base for node16 version
- modified make.json to remove it from azure-arm-rest package
- replaced util.error to Error
- Fixed test since the handler was incorrect
- removed duplicate task lib
@DmitriiBobreshev DmitriiBobreshev merged commit 0568d10 into master Jul 24, 2023
@DmitriiBobreshev DmitriiBobreshev deleted the user/dmitriibobreshev/usedotnet_node16 branch July 24, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants