Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AzureIoTEdgeV2] Update to Node 16 #18557

Merged
merged 12 commits into from
Jul 19, 2023
Merged

[AzureIoTEdgeV2] Update to Node 16 #18557

merged 12 commits into from
Jul 19, 2023

Conversation

aleksandrlevochkin
Copy link
Contributor

Task name: AzureIoTEdgeV2

Description:

  • Generated new task
  • Added package.json and package-lock.json to original task for Node16
  • Fixed types for fs.readFileSync signature in Node 16

Documentation changes required: N

Added unit tests: N

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@aleksandrlevochkin aleksandrlevochkin marked this pull request as ready for review June 27, 2023 10:14
@aleksandrlevochkin aleksandrlevochkin requested a review from a team June 27, 2023 14:37
DmitriiBobreshev and others added 4 commits July 13, 2023 03:16
@DmitriiBobreshev @aleksandrlevochkin
Introduce Node16-225 for buildconfig
dd4156b 
- Switched config key from Node16-219 to Node16-225
- Added overriddenDirectoryName to set generated directory postfix
@DmitriiBobreshev @aleksandrlevochkin
Introduce Node16-225 for buildconfig
9cbc2cb 
- Added deprecation option
@aleksandrlevochkin
Merge
e3e074c
@aleksandrlevochkin
Resolved merging conflicts
788f1a1
@aleksandrlevochkin aleksandrlevochkin merged commit fb48946 into master Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmapetr vmapetr vmapetr left review comments

@Pranshu-Negi Pranshu-Negi Pranshu-Negi approved these changes

@kirill-ivlev kirill-ivlev kirill-ivlev approved these changes

@marianan marianan Awaiting requested review from marianan marianan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aleksandrlevochkin @vmapetr @kirill-ivlev @Pranshu-Negi @DmitriiBobreshev