Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PackerBuild] Merge generated tasks with the base tasks #18542

Merged
merged 4 commits into from
Jun 27, 2023
Merged

[PackerBuild] Merge generated tasks with the base tasks #18542

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
96e8b0d
[PackerBuild] Merge generated tasks with the base tasks
DmitriiBobreshev Jun 23, 2023
ec9dc00
[PackerBuild] Merge generated tasks with the base tasks
DmitriiBobreshev Jun 23, 2023
0642fc7
Merge branch 'master' into user/dmitriibobreshev/packerbuild_node16_m…
DmitriiBobreshev Jun 25, 2023
1036ef7
Merge branch 'master' into user/dmitriibobreshev/packerbuild_node16_m…
DmitriiBobreshev Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Tasks/PackerBuildV0/_buildConfigs/Node16/FilesOverriddenForConfigGoHereREADME.txt
View file
Open in desktop

This file was deleted.

808 changes: 0 additions & 808 deletions Tasks/PackerBuildV0/_buildConfigs/Node16/package-lock.json
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions Tasks/PackerBuildV0/_buildConfigs/Node16/package.json
View file
Open in desktop

This file was deleted.

151 changes: 86 additions & 65 deletions Tasks/PackerBuildV0/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Tasks/PackerBuildV0/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
"main": "main.js",
"dependencies": {
"@types/mocha": "^5.2.7",
"@types/node": "^10.17.0",
"@types/node": "^16.11.39",
"@types/q": "^1.0.7",
"azure-pipelines-task-lib": "^3.0.6-preview.0",
"azure-pipelines-task-lib": "^4.3.1",
"azure-pipelines-tasks-azure-arm-rest-v2": "^3.217.1",
"decompress-zip": "^0.3.3",
"moment": "^2.29.4"
Expand Down
6 changes: 1 addition & 5 deletions Tasks/PackerBuildV0/src/utilities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,9 @@ export async function download(url: string, downloadPath: string): Promise<void>
req.end();
});

#if NODE16
if (!file.writableEnded) {
file.end(null, null, file.close);
}
#else
file.end(null, null, file.close);
#endif
}

export async function unzip(zipLocation, unzipLocation): Promise<string> {
Expand Down Expand Up @@ -209,4 +205,4 @@ export class PackerVersion {
patch: parseInt(parts[2])
};
}
}
}
6 changes: 5 additions & 1 deletion Tasks/PackerBuildV0/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"version": {
"Major": 0,
"Minor": 224,
"Patch": 1
"Patch": 2
},
"demands": [],
"minimumAgentVersion": "2.0.0",
Expand Down Expand Up @@ -259,6 +259,10 @@
"execution": {
"Node10": {
"target": "src//main.js"
},
"Node16": {
"target": "src//main.js",
"argumentFormat": ""
}
},
"messages": {
Expand Down
Loading