Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkbox for JSONStringify #18526

Merged
6 commits merged into from
Jun 22, 2023
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jun 21, 2023

Task name: AzureResourceGroupDeploymentV2, AzureResourceManagerTemplateDeploymentV3

Description: Added a new checkbox to make it possible to disable JSON.Stringify for deployment outputs

image

Documentation changes required: (Y/N) Y

https://github.com/microsoft/azure-pipelines-tasks/blob/f0644fb5a1710fd69f4a3f51298a7d555ba0f15c/Tasks/AzureResourceGroupDeploymentV2/README.md#deployment-outputs

https://github.com/microsoft/azure-pipelines-tasks/blob/f0644fb5a1710fd69f4a3f51298a7d555ba0f15c/Tasks/AzureResourceManagerTemplateDeploymentV3/README.md#deployment-outputs

Added unit tests: (Y/N) N

Attached related issue: (Y/N)

Issue based on this PR #16283

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

Since both task are sharing same "id" but naming is different, ci-test can't group them correctly.
I manually triggered ci-test-tasks-main

@ghost ghost requested review from rvairavelu and manolerazvan as code owners June 21, 2023 10:57
@ghost ghost merged commit 1041349 into master Jun 22, 2023
@ghost ghost deleted the users/ozanaydin/deployment-output-json-fix branch June 22, 2023 13:15
@svrooij
Copy link

svrooij commented Jun 22, 2023

Thanks for completely removing my name as contributor… #16283

you can always make someone co-author, by adding something to the commit message. https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants