Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Initialize-AzSubscription function #18289

Merged
merged 19 commits into from
Jun 26, 2023
Merged

Fix Initialize-AzSubscription function #18289

merged 19 commits into from
Jun 26, 2023

Conversation

DenisRumyantsev
Copy link
Contributor

@DenisRumyantsev DenisRumyantsev commented May 16, 2023 •
edited
Loading

Tasks list:

  • AzureCloudPowerShellDeploymentV1
  • AzureCloudPowerShellDeploymentV2
  • AzureFileCopyV2
  • AzureFileCopyV3
  • AzureFileCopyV4
  • AzureFileCopyV5
  • AzurePowerShellV2
  • AzurePowerShellV3
  • AzurePowerShellV4
  • AzurePowerShellV5
  • SqlAzureDacpacDeploymentV1

Description: Added clearing default subscription for login in the Initialize-AzSubscription function, used in the Initialize-AzModule function, used in the AzureFileCopy task, in order to always use the subscription specified in the related azureSubscription (connectedServiceName) task input.

Documentation changes required: No

Added unit tests: No

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@v-nagarajku
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@v-nagarajku
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@v-nagarajku
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@v-nagarajku
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@v-nagarajku
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@v-nagarajku
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@v-nagarajku
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@v-nagarajku
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@v-nagarajku
Copy link
Contributor

@DenisRumyantsev can you please bump the version to 223, as the current sprint is 223 week 2

@DenisRumyantsev
Copy link
Contributor Author

@DenisRumyantsev can you please bump the version to 223, as the current sprint is 223 week 2

@v-nagarajku done

@v-nagarajku
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@v-nagarajku
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@v-nagarajku
Copy link
Contributor

/azp run

@v-nagarajku
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@v-nagarajku
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@v-nagarajku
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@v-nagarajku
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@v-nagarajku
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

v-nagarajku
v-nagarajku approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@v-nagarajku v-nagarajku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks are failing and manually running the pipeline in AzDevOps pipelines.

@DenisRumyantsev
Copy link
Contributor Author

These failed checks can be successfully manually rerun with the skipBumpingVersionsDueToChangesInCommon pipeline variable enabled, so automatic failed checks are not an issue.

ghost
ghost suggested changes Jun 21, 2023
View reviewed changes
Copy link

@ghost ghost left a comment •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need one more bump for AzureFileCopyV4 and V5 ; please wait before the merge.

Could you please update AzureFileCopyV4 and AzureFileCopyV5 according to latest master branch?

@ghost ghost self-requested a review June 21, 2023 15:04
@v-nagarajku
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@DenisRumyantsev DenisRumyantsev merged commit a708b3d into master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-nagarajku v-nagarajku v-nagarajku approved these changes

@rvairavelu rvairavelu Awaiting requested review from rvairavelu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DenisRumyantsev @v-nagarajku