Update FuncToolsInstallerV0 to node16 using BuildConfigGen #18251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- Updated tasks to Node16 using buiildConfigGenerator -- Files in _generated folder was generated using node make.js gentask --configs Node16 --task PackerBuild* command -- Added _buildConfigs\Node16\package.json to both tasks to bump task-lib -- Fixed error check with package-lock.json
-- changed library to be removed in make.js
KonstantinTyukalov
approved these changes
May 8, 2023
max-zaytsev
approved these changes
May 8, 2023
LiliaSabitova
approved these changes
May 8, 2023
merlynomsft
reviewed
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: FuncToolsInstallerV0
Description:
-- Updated tasks to Node16 using buiildConfigGenerator
-- Files in _generated folder were generated using node make.js gentask --configs Node16 --task PackerBuild* command
-- Added _buildConfigs\Node16\package.json to both tasks to bump task-lib
-- Fixed error check with package-lock.json
Documentation changes required: N
Added unit tests: N
Checklist: