Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use @tsconfig/node10 #18111

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Conversation

JamieMagee
Copy link
Member

@JamieMagee JamieMagee commented Apr 13, 2023

Task name: BashV3

Description: Migrate from custom tsconfig.json to @tsconfig/node10. See #18118 for more information

Documentation changes required: N

Added unit tests: N

Attached related issue: #18118

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@JamieMagee JamieMagee requested a review from a team as a code owner April 13, 2023 17:17
@JamieMagee JamieMagee force-pushed the bash-tsconfig-node10 branch from 69c5b62 to 67cddca Compare April 15, 2023 21:47
@JamieMagee JamieMagee force-pushed the bash-tsconfig-node10 branch 2 times, most recently from c2eb920 to 6c20fa5 Compare June 15, 2023 15:25
@JamieMagee JamieMagee force-pushed the bash-tsconfig-node10 branch from 6c20fa5 to 09e8406 Compare July 14, 2023 04:21
@JamieMagee

This comment was marked as outdated.

@azure-pipelines

This comment was marked as outdated.

@JamieMagee

This comment was marked as outdated.

@JamieMagee

This comment was marked as outdated.

@azure-pipelines

This comment was marked as outdated.

@JamieMagee JamieMagee force-pushed the bash-tsconfig-node10 branch 3 times, most recently from 58d5128 to f61f328 Compare July 14, 2023 17:21
@JamieMagee JamieMagee requested a review from qianz2 July 14, 2023 17:23
@JamieMagee JamieMagee force-pushed the bash-tsconfig-node10 branch from f61f328 to 74508c3 Compare August 2, 2023 03:36
Equivalent to

```json
{
  "$schema": "https://json.schemastore.org/tsconfig",
  "display": "Node 10",

  "compilerOptions": {
    "lib": ["es2018"],
    "module": "commonjs",
    "target": "es2018",

    "strict": true,
    "esModuleInterop": true,
    "skipLibCheck": true,
    "forceConsistentCasingInFileNames": true,
    "moduleResolution": "node"
  }
}
```
@JamieMagee JamieMagee force-pushed the bash-tsconfig-node10 branch from 74508c3 to caf485f Compare August 2, 2023 03:43
@JamieMagee JamieMagee merged commit 0e701b6 into microsoft:master Aug 2, 2023
@JamieMagee JamieMagee deleted the bash-tsconfig-node10 branch August 2, 2023 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants