Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set USE_MSAL to false in unit tests #18064

Merged
4 commits merged into from
Apr 4, 2023
Merged

Set USE_MSAL to false in unit tests #18064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b2d1dc9
Set USE_MSAL to false in tests
onetocny Apr 4, 2023
1e76b51
Remove useMsal param from AzureRmWebAppDeploymentProvider
onetocny Apr 4, 2023
b19aff8
Clean up msal paramteres
onetocny Apr 4, 2023
2c4e810
Bump up version
onetocny Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Tasks/AzureRmWebAppDeploymentV4/Tests/AzureRmWebAppDeploymentProviderL0Tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export class AzureRmWebAppDeploymentProviderL0Tests {
try {
var taskParameters: TaskParameters = TaskParametersUtility.getParameters();
var azureRmWebAppDeploymentProvider : AzureRmWebAppDeploymentProvider = new AzureRmWebAppDeploymentProvider(taskParameters);
await azureRmWebAppDeploymentProvider.PreDeploymentStep(false);
await azureRmWebAppDeploymentProvider.PreDeploymentStep();
} catch(error) {
tl.setResult(tl.TaskResult.Failed, 'PreDeployment steps should succeeded but failed with error');
}
Expand All @@ -36,7 +36,7 @@ export class AzureRmWebAppDeploymentProviderL0Tests {
taskParameters.DeployToSlotOrASEFlag = true;
taskParameters.ResourceGroupName = "MOCK_RESOURCE_GROUP_NAME";
var azureRmWebAppDeploymentProvider : AzureRmWebAppDeploymentProvider = new AzureRmWebAppDeploymentProvider(taskParameters);
await azureRmWebAppDeploymentProvider.PreDeploymentStep(false);
await azureRmWebAppDeploymentProvider.PreDeploymentStep();
tl.setResult(tl.TaskResult.Succeeded, 'PreDeployment steps with slot enabled should succeeded');
} catch(error) {
tl.setResult(tl.TaskResult.Failed, 'PreDeployment steps with slot enabled failed with error');
Expand All @@ -50,7 +50,7 @@ export class AzureRmWebAppDeploymentProviderL0Tests {
taskParameters.ResourceGroupName = "MOCK_RESOURCE_GROUP_NAME";
taskParameters.VirtualApplication = "VirtualApplication";
var azureRmWebAppDeploymentProvider : AzureRmWebAppDeploymentProvider = new AzureRmWebAppDeploymentProvider(taskParameters);
await azureRmWebAppDeploymentProvider.PreDeploymentStep(false);
await azureRmWebAppDeploymentProvider.PreDeploymentStep();
tl.setResult(tl.TaskResult.Succeeded, 'PreDeployment steps with virtual application should succeeded');
} catch(error) {
tl.setResult(tl.TaskResult.Failed, 'PreDeployment steps with virtual application failed with error');
Expand All @@ -61,7 +61,7 @@ export class AzureRmWebAppDeploymentProviderL0Tests {
try {
var taskParameters: TaskParameters = TaskParametersUtility.getParameters();
var azureRmWebAppDeploymentProvider : AzureRmWebAppDeploymentProvider = new AzureRmWebAppDeploymentProvider(taskParameters);
await azureRmWebAppDeploymentProvider.PreDeploymentStep(false);
await azureRmWebAppDeploymentProvider.PreDeploymentStep();
await azureRmWebAppDeploymentProvider.UpdateDeploymentStatus(true);
} catch(error) {
tl.setResult(tl.TaskResult.Failed, 'UpdateDeploymentStatus steps should succeeded but failed with error');
Expand Down
14 changes: 7 additions & 7 deletions Tasks/AzureRmWebAppDeploymentV4/Tests/BuiltInLinuxWebAppDeploymentProviderL0Tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export class BuiltInLinuxWebAppDeploymentProviderL0Tests {
try {
var taskParameters: TaskParameters = TaskParametersUtility.getParameters();
var builtInLinuxWebAppDeploymentProvider : BuiltInLinuxWebAppDeploymentProvider = new BuiltInLinuxWebAppDeploymentProvider(taskParameters);
await builtInLinuxWebAppDeploymentProvider.PreDeploymentStep(false);
await builtInLinuxWebAppDeploymentProvider.PreDeploymentStep();
tl.setResult(tl.TaskResult.Succeeded, 'PreDeployment steps for built in linux web app should succeeded');
} catch(error) {
tl.setResult(tl.TaskResult.Failed, 'PreDeployment steps for built in linux web app failed with error');
Expand All @@ -41,7 +41,7 @@ export class BuiltInLinuxWebAppDeploymentProviderL0Tests {
taskParameters.DeployToSlotOrASEFlag = true;
taskParameters.ResourceGroupName = "MOCK_RESOURCE_GROUP_NAME";
var builtInLinuxWebAppDeploymentProvider : BuiltInLinuxWebAppDeploymentProvider = new BuiltInLinuxWebAppDeploymentProvider(taskParameters);
await builtInLinuxWebAppDeploymentProvider.PreDeploymentStep(false);
await builtInLinuxWebAppDeploymentProvider.PreDeploymentStep();
tl.setResult(tl.TaskResult.Succeeded, 'PreDeployment steps for built in linux web app with slot enabled should succeeded');
} catch(error) {
tl.setResult(tl.TaskResult.Failed, 'PreDeployment steps for built in linux web app with slot enabled failed with error');
Expand All @@ -52,7 +52,7 @@ export class BuiltInLinuxWebAppDeploymentProviderL0Tests {
try {
var taskParameters: TaskParameters = TaskParametersUtility.getParameters();
var builtInLinuxWebAppDeploymentProvider : BuiltInLinuxWebAppDeploymentProvider = new BuiltInLinuxWebAppDeploymentProvider(taskParameters);
await builtInLinuxWebAppDeploymentProvider.PreDeploymentStep(false);
await builtInLinuxWebAppDeploymentProvider.PreDeploymentStep();
await builtInLinuxWebAppDeploymentProvider.UpdateDeploymentStatus(true);
} catch(error) {
tl.setResult(tl.TaskResult.Failed, 'UpdateDeploymentStatus for built in linux web app steps should succeeded but failed with error');
Expand All @@ -63,7 +63,7 @@ export class BuiltInLinuxWebAppDeploymentProviderL0Tests {
try {
var taskParameters: TaskParameters = TaskParametersUtility.getParameters();
var builtInLinuxWebAppDeploymentProvider : BuiltInLinuxWebAppDeploymentProvider = new BuiltInLinuxWebAppDeploymentProvider(taskParameters);
await builtInLinuxWebAppDeploymentProvider.PreDeploymentStep(false);
await builtInLinuxWebAppDeploymentProvider.PreDeploymentStep();
await builtInLinuxWebAppDeploymentProvider.DeployWebAppStep();
tl.setResult(tl.TaskResult.Succeeded, 'DeployWebAppStep for built in linux web app steps with zip package succeeded');
} catch(error) {
Expand All @@ -77,7 +77,7 @@ export class BuiltInLinuxWebAppDeploymentProviderL0Tests {
taskParameters.Package.getPackageType = () :PackageType => {return PackageType.folder};
taskParameters.Package.getPath = () :string => { return "webAppPkg" };
var builtInLinuxWebAppDeploymentProvider : BuiltInLinuxWebAppDeploymentProvider = new BuiltInLinuxWebAppDeploymentProvider(taskParameters);
await builtInLinuxWebAppDeploymentProvider.PreDeploymentStep(false);
await builtInLinuxWebAppDeploymentProvider.PreDeploymentStep();
await builtInLinuxWebAppDeploymentProvider.DeployWebAppStep();
tl.setResult(tl.TaskResult.Succeeded, 'DeployWebAppStep for built in linux web app steps with folder package succeeded');
} catch(error) {
Expand All @@ -91,7 +91,7 @@ export class BuiltInLinuxWebAppDeploymentProviderL0Tests {
taskParameters.Package.getPackageType = () :PackageType => {return PackageType.war};
taskParameters.Package.getPath = () :string => { return "webAppPkg.war" };
var builtInLinuxWebAppDeploymentProvider : BuiltInLinuxWebAppDeploymentProvider = new BuiltInLinuxWebAppDeploymentProvider(taskParameters);
await builtInLinuxWebAppDeploymentProvider.PreDeploymentStep(false);
await builtInLinuxWebAppDeploymentProvider.PreDeploymentStep();
await builtInLinuxWebAppDeploymentProvider.DeployWebAppStep();
tl.setResult(tl.TaskResult.Succeeded, 'DeployWebAppStep for built in linux web app steps with war package succeeded');
} catch(error) {
Expand All @@ -105,7 +105,7 @@ export class BuiltInLinuxWebAppDeploymentProviderL0Tests {
taskParameters.Package.getPackageType = () :PackageType => {return PackageType.jar};
taskParameters.Package.getPath = () :string => { return "webAppPkg.jar" };
var builtInLinuxWebAppDeploymentProvider : BuiltInLinuxWebAppDeploymentProvider = new BuiltInLinuxWebAppDeploymentProvider(taskParameters);
await builtInLinuxWebAppDeploymentProvider.PreDeploymentStep(false);
await builtInLinuxWebAppDeploymentProvider.PreDeploymentStep();
await builtInLinuxWebAppDeploymentProvider.DeployWebAppStep();
tl.setResult(tl.TaskResult.Succeeded, 'DeployWebAppStep for built in linux web app steps with jar package succeeded');
} catch(error) {
Expand Down
8 changes: 4 additions & 4 deletions Tasks/AzureRmWebAppDeploymentV4/Tests/ContainerWebAppDeploymentProviderL0Tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export class ContainerWebAppDeploymentProviderL0Tests {
try {
var taskParameters: TaskParameters = TaskParametersUtility.getParameters();
var containerWebAppDeploymentProvider : ContainerWebAppDeploymentProvider = new ContainerWebAppDeploymentProvider(taskParameters);
await containerWebAppDeploymentProvider.PreDeploymentStep(false);
await containerWebAppDeploymentProvider.PreDeploymentStep();
tl.setResult(tl.TaskResult.Succeeded, 'PreDeployment steps for container web app should succeeded');
} catch(error) {
tl.setResult(tl.TaskResult.Failed, 'PreDeployment steps for container web app failed with error');
Expand All @@ -38,7 +38,7 @@ export class ContainerWebAppDeploymentProviderL0Tests {
taskParameters.DeployToSlotOrASEFlag = true;
taskParameters.ResourceGroupName = "MOCK_RESOURCE_GROUP_NAME";
var containerWebAppDeploymentProvider : ContainerWebAppDeploymentProvider = new ContainerWebAppDeploymentProvider(taskParameters);
await containerWebAppDeploymentProvider.PreDeploymentStep(false);
await containerWebAppDeploymentProvider.PreDeploymentStep();
tl.setResult(tl.TaskResult.Succeeded, 'PreDeployment steps for container web app with slot enabled should succeeded');
} catch(error) {
tl.setResult(tl.TaskResult.Failed, 'PreDeployment steps for container web app with slot enabled failed with error');
Expand All @@ -49,7 +49,7 @@ export class ContainerWebAppDeploymentProviderL0Tests {
try {
var taskParameters: TaskParameters = TaskParametersUtility.getParameters();
var containerWebAppDeploymentProvider : ContainerWebAppDeploymentProvider = new ContainerWebAppDeploymentProvider(taskParameters);
await containerWebAppDeploymentProvider.PreDeploymentStep(false);
await containerWebAppDeploymentProvider.PreDeploymentStep();
await containerWebAppDeploymentProvider.UpdateDeploymentStatus(true);
} catch(error) {
tl.setResult(tl.TaskResult.Failed, 'UpdateDeploymentStatus for container web app steps should succeeded but failed with error');
Expand All @@ -61,7 +61,7 @@ export class ContainerWebAppDeploymentProviderL0Tests {
var taskParameters: TaskParameters = TaskParametersUtility.getParameters();
taskParameters.ScriptType = null;
var containerWebAppDeploymentProvider : ContainerWebAppDeploymentProvider = new ContainerWebAppDeploymentProvider(taskParameters);
await containerWebAppDeploymentProvider.PreDeploymentStep(false);
await containerWebAppDeploymentProvider.PreDeploymentStep();
await containerWebAppDeploymentProvider.DeployWebAppStep();
tl.setResult(tl.TaskResult.Succeeded, 'Web app Deployment steps for container should succeeded');
} catch(error) {
Expand Down
10 changes: 5 additions & 5 deletions Tasks/AzureRmWebAppDeploymentV4/Tests/WindowsWebAppRunFromZipProviderL0Tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export class WindowsWebAppRunFromZipProviderL0Tests {
try {
var taskParameters: TaskParameters = TaskParametersUtility.getParameters();
var windowsWebAppRunFromZipProvider : WindowsWebAppRunFromZipProvider = new WindowsWebAppRunFromZipProvider(taskParameters);
await windowsWebAppRunFromZipProvider.PreDeploymentStep(false);
await windowsWebAppRunFromZipProvider.PreDeploymentStep();
tl.setResult(tl.TaskResult.Succeeded, 'PreDeployment steps for run from zip should succeeded');
} catch(error) {
tl.setResult(tl.TaskResult.Failed, 'PreDeployment steps for built in run from zip failed with error');
Expand All @@ -39,7 +39,7 @@ export class WindowsWebAppRunFromZipProviderL0Tests {
taskParameters.DeployToSlotOrASEFlag = true;
taskParameters.ResourceGroupName = "MOCK_RESOURCE_GROUP_NAME";
var windowsWebAppRunFromZipProvider : WindowsWebAppRunFromZipProvider = new WindowsWebAppRunFromZipProvider(taskParameters);
await windowsWebAppRunFromZipProvider.PreDeploymentStep(false);
await windowsWebAppRunFromZipProvider.PreDeploymentStep();
tl.setResult(tl.TaskResult.Succeeded, 'PreDeployment steps for run from zip with slot enabled should succeeded');
} catch(error) {
tl.setResult(tl.TaskResult.Failed, 'PreDeployment steps for run from zip with slot enabled failed with error');
Expand All @@ -51,7 +51,7 @@ export class WindowsWebAppRunFromZipProviderL0Tests {
var taskParameters: TaskParameters = TaskParametersUtility.getParameters();
taskParameters.ScriptType = "Run Script";
var windowsWebAppRunFromZipProvider : WindowsWebAppRunFromZipProvider = new WindowsWebAppRunFromZipProvider(taskParameters);
await windowsWebAppRunFromZipProvider.PreDeploymentStep(false);
await windowsWebAppRunFromZipProvider.PreDeploymentStep();
await windowsWebAppRunFromZipProvider.UpdateDeploymentStatus(true);
} catch(error) {
tl.setResult(tl.TaskResult.Failed, 'UpdateDeploymentStatus for run from zip steps should succeeded but failed with error');
Expand All @@ -64,7 +64,7 @@ export class WindowsWebAppRunFromZipProviderL0Tests {
taskParameters.Package.getPackageType = () :PackageType => {return PackageType.zip};
taskParameters.Package.getPath = () :string => { return "webAppPkg.zip" };
var windowsWebAppRunFromZipProvider : WindowsWebAppRunFromZipProvider = new WindowsWebAppRunFromZipProvider(taskParameters);
await windowsWebAppRunFromZipProvider.PreDeploymentStep(false);
await windowsWebAppRunFromZipProvider.PreDeploymentStep();
await windowsWebAppRunFromZipProvider.DeployWebAppStep();
tl.setResult(tl.TaskResult.Succeeded, 'DeployWebAppStep for run from zip steps with zip package succeeded');
} catch(error) {
Expand All @@ -78,7 +78,7 @@ export class WindowsWebAppRunFromZipProviderL0Tests {
taskParameters.Package.getPackageType = () :PackageType => {return PackageType.folder};
taskParameters.Package.getPath = () :string => { return "webAppPkg" };
var windowsWebAppRunFromZipProvider : WindowsWebAppRunFromZipProvider = new WindowsWebAppRunFromZipProvider(taskParameters);
await windowsWebAppRunFromZipProvider.PreDeploymentStep(false);
await windowsWebAppRunFromZipProvider.PreDeploymentStep();
await windowsWebAppRunFromZipProvider.DeployWebAppStep();
tl.setResult(tl.TaskResult.Succeeded, 'DeployWebAppStep for run from zip steps with folder package succeeded');
} catch(error) {
Expand Down
8 changes: 4 additions & 4 deletions Tasks/AzureRmWebAppDeploymentV4/Tests/WindowsWebAppWarDeployProviderL0Tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export class WindowsWebAppWarDeployProviderL0Tests {
taskParameters.Package.getPackageType = () :PackageType => {return PackageType.war};
taskParameters.Package.getPath = () :string => { return "webAppPkg.war" };
var windowsWebAppWarDeployProvider : WindowsWebAppWarDeployProvider = new WindowsWebAppWarDeployProvider(taskParameters);
await windowsWebAppWarDeployProvider.PreDeploymentStep(false);
await windowsWebAppWarDeployProvider.PreDeploymentStep();
tl.setResult(tl.TaskResult.Succeeded, 'PreDeployment steps for war deploy should succeeded');
} catch(error) {
tl.setResult(tl.TaskResult.Failed, 'PreDeployment steps for war deploy failed with error');
Expand All @@ -42,7 +42,7 @@ export class WindowsWebAppWarDeployProviderL0Tests {
taskParameters.DeployToSlotOrASEFlag = true;
taskParameters.ResourceGroupName = "MOCK_RESOURCE_GROUP_NAME";
var windowsWebAppWarDeployProvider : WindowsWebAppWarDeployProvider = new WindowsWebAppWarDeployProvider(taskParameters);
await windowsWebAppWarDeployProvider.PreDeploymentStep(false);
await windowsWebAppWarDeployProvider.PreDeploymentStep();
tl.setResult(tl.TaskResult.Succeeded, 'PreDeployment steps for war deploy with slot enabled should succeeded');
} catch(error) {
tl.setResult(tl.TaskResult.Failed, 'PreDeployment steps for war deploy with slot enabled failed with error');
Expand All @@ -55,7 +55,7 @@ export class WindowsWebAppWarDeployProviderL0Tests {
taskParameters.Package.getPackageType = () :PackageType => {return PackageType.war};
taskParameters.Package.getPath = () :string => { return "webAppPkg.war" };
var windowsWebAppWarDeployProvider : WindowsWebAppWarDeployProvider = new WindowsWebAppWarDeployProvider(taskParameters);
await windowsWebAppWarDeployProvider.PreDeploymentStep(false);
await windowsWebAppWarDeployProvider.PreDeploymentStep();
await windowsWebAppWarDeployProvider.UpdateDeploymentStatus(true);
} catch(error) {
tl.setResult(tl.TaskResult.Failed, 'UpdateDeploymentStatus for war deploy steps should succeeded but failed with error');
Expand All @@ -68,7 +68,7 @@ export class WindowsWebAppWarDeployProviderL0Tests {
taskParameters.Package.getPackageType = () :PackageType => {return PackageType.war};
taskParameters.Package.getPath = () :string => { return "webAppPkg.war" };
var windowsWebAppWarDeployProvider : WindowsWebAppWarDeployProvider = new WindowsWebAppWarDeployProvider(taskParameters);
await windowsWebAppWarDeployProvider.PreDeploymentStep(false);
await windowsWebAppWarDeployProvider.PreDeploymentStep();
await windowsWebAppWarDeployProvider.DeployWebAppStep();
tl.setResult(tl.TaskResult.Succeeded, 'DeployWebAppStep for war deploy steps with war package succeeded');
} catch(error) {
Expand Down
Loading