Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGetCommandV2 : rev patch version to pick up changes #17627

Merged
merged 10 commits into from
Jan 19, 2023

Conversation

embetten
Copy link
Contributor

@embetten embetten commented Jan 19, 2023

Task name: NuGetCommandV2

Description: Version Rev

Documentation changes required: (Y/N) N

Added unit tests: (Y/N) NA

Attached related issue: (Y/N) NA

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@embetten
Copy link
Contributor Author

embetten commented Jan 19, 2023

This PR is needed because multiple PRs (#17163, #17311, #17265, #17325, #17297) rev'd the NuGetCommandV2 2.214.x version around the same time. This caused merge conflicts on the task.json and the task.loc.json.

The automatic merge resolver for the final #17297 PR reverted the latest patch updates:
see 6257fd5
image

Thus the changes did not get deployed to master. Downloading 2.214.2 and 2.214.3 nupkg from the feeds show the code changes are not present:
image

Thus reving just the version to force the changes to be picked up and deployed.

note: dotnetcorecliv2 task was also affected, but other changes have reved the task version and the currently deployed task version has the changes

@embetten embetten marked this pull request as ready for review January 19, 2023 00:31
@embetten embetten requested a review from a team as a code owner January 19, 2023 00:31
@embetten embetten changed the title rev minor version NuGetCommandV2 : rev patch version to pick up changes Jan 19, 2023
@embetten
Copy link
Contributor Author

embetten commented Jan 19, 2023

Tested:
image

@embetten embetten merged commit 5c525dc into microsoft:master Jan 19, 2023
@embetten embetten deleted the users/embetten/nugetCommandV2 branch January 19, 2023 19:44
embetten added a commit to embetten/azure-pipelines-tasks that referenced this pull request Jan 19, 2023
* rev minor version

* task.json

* update make file

* revert

* downgrading task version to 216 to hotfix with current release
embetten added a commit that referenced this pull request Jan 19, 2023
* rev minor version

* task.json

* update make file

* revert

* downgrading task version to 216 to hotfix with current release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants