Rename to AzureSpringApps #17471

yitaopan · 2022-12-13T06:48:09Z

Task name: AzureSpringCloudV0

Description: Rename Azure Spring Cloud too Azure Spring Apps (the new name of this service), keep task name so this task can still be referenced.

Documentation changes required: (Y/N) Y

Added unit tests: (Y/N) N

Attached related issue: (Y/N) N

Checklist:

Task version was bumped - please check instruction how to do it
Checked that applied changes work as expected

bowen5 · 2022-12-14T13:18:43Z

Tasks/AzureSpringCloudV0/deploymentProvider/AzureSpringCloudDeploymentProvider.ts

@@ -30,7 +30,7 @@ export class AzureSpringCloudDeploymentProvider {
        var azureSpringCloudResourceId: string;
        if (this.taskParameters.AzureSpringCloud.startsWith('/')) {
            if (this.taskParameters.AzureSpringCloud.includes('..')){{
-                throw Error(tl.loc('InvalidAzureSpringCloudResourceId', 'this.taskParameters.AzureSpringCloud'));
+                throw Error(tl.loc('InvalidAzureSpringAppsResourceId', 'this.taskParameters.AzureSpringCloud'));


Do we need to change "this.taskParameters.AzureSpringCloud"?

bowen5 · 2022-12-14T13:19:10Z

Tasks/AzureSpringCloudV0/operations/taskparameters.ts

@@ -2,7 +2,7 @@ import { Package, PackageType } from 'azure-pipelines-tasks-webdeployment-common

 export class Inputs {
    public static readonly connectedServiceName = 'ConnectedServiceName';
-    public static readonly azureSpringCloud = 'AzureSpringCloud';
+    public static readonly azureSpringCloud = 'AzureSpringApps';


If won't introduce breaking, how about change this param name "azureSpringCloud" as well?

Yes, this could introduce breaking, I will change it back.

bowen5 · 2023-01-04T12:47:09Z

Tasks/AzureSpringCloudV0/package-lock.json

@@ -468,7 +468,7 @@
        "xmldom": "^0.1.27"
      }
    },
-    "node_modules/azure-pipelines-tasks-webdeployment-common-v4/node_modules/@types/mocha": {
+    "node_modules/azure-pipelines-tasks-webdeployment-common/node_modules/@types/mocha": {


Just double confirm: it is by design to drop the "v4" instead of make it "v5", right?

There might be some conflict with master branch, let me double check.

bowen5 · 2023-01-04T12:47:52Z

Tasks/AzureSpringCloudV0/deploymentProvider/azure-arm-spring-cloud.ts

@@ -246,6 +246,10 @@ export class AzureSpringCloud {
                    throw ToError(response);
                }
                provisioningState = response.body.properties.provisioningState;
+                if (provisioningState == "Failed"){


Good catch.

bowen5 · 2023-01-04T12:48:54Z

Tasks/AzureSpringCloudV0/azurespringclouddeployment.ts

@@ -2,7 +2,7 @@
 import tl = require('azure-pipelines-task-lib/task');
 import { TaskParameters, TaskParametersUtility } from './operations/taskparameters';

-import { AzureSpringCloudDeploymentProvider } from './deploymentProvider/AzureSpringCloudDeploymentProvider'
+import { AzureSpringAppsDeploymentProvider } from './deploymentProvider/AzureSpringCloudDeploymentProvider'


Are we able to change "AzureSpringCloudDeploymentProvider"? Probably need to renam the file .

Ok, will do, I was about to check with you whether this is needed.

Thanks, good to know that.

bowen5 · 2023-01-05T09:45:08Z

LGTM.

Tasks/AzureSpringCloudV0/operations/taskparameters.ts

mmrazik · 2023-04-03T08:42:48Z

/azp run

azure-pipelines · 2023-04-03T08:43:09Z

Azure Pipelines successfully started running 4 pipeline(s).

bowen5 · 2023-04-06T12:24:16Z

@kirill-ivlev @vmapetr @mmrazik can any of you help to merge? Thanks.

KonstantinTyukalov · 2023-04-10T12:16:44Z

@bowen5 please, resolve PR conflicts.
Also, it seems you have some issues with dependencies files:
https://dev.azure.com/mseng/PipelineTools/_build/results?buildId=19626785&view=logs&j=55b94f1c-9d32-5114-bc90-83768ebbe0df&t=8334df59-c1ae-533d-4d46-13427016ffd1&l=18

> git diff --name-only /home/vsts/work/1/s/Tasks/AzureSpringCloudV0
Tasks/AzureSpringCloudV0/Tests/package-lock.json
Tasks/AzureSpringCloudV0/package-lock.json

Uncommitted changes found:

 - Tasks/AzureSpringCloudV0/Tests/package-lock.json

 - Tasks/AzureSpringCloudV0/package-lock.json


Please build your tasks locally and commit specified changes:

 - Tasks/AzureSpringCloudV0/Tests/package-lock.json
 - Tasks/AzureSpringCloudV0/package-lock.json

Make sure you are using Node 10 and NPM 6. For more details check our contribution guide - ***/blob/master/docs/contribute.md

yitaopan · 2023-04-12T14:30:47Z

@KonstantinTyukalov Hi, thanks, I have merged master branch and rebuild the task using Node 10 and NPM 6. Can you please take a look again?

KonstantinTyukalov

LGTM, but please check few comments and bump task version according to the current sprint

KonstantinTyukalov · 2023-04-12T15:08:31Z

Tasks/AzureSpringCloudV0/deploymentProvider/azure-arm-spring-apps.ts

+                if (provisioningState == "Failed"){
+                    tl.debug('KPack build failed');
+                    throw ToError(response);
+                }


[Suggestion] These changes aren't seems related to rebranding 😃
Probably, make sense to move it into separate PR, but it's up to you

Thanks, sorry I didn't pointed this out, this would be a small ux improvement I think I could include here.

KonstantinTyukalov · 2023-04-12T15:09:11Z

Tasks/AzureSpringCloudV0/package.json

@@ -25,14 +25,15 @@
    "@types/mocha": "8.2.1",
    "@types/node": "^10.17.0",
    "@types/q": "1.0.7",
-    "JSONPath": "^0.11.2",
+    "@xmldom/xmldom": "^0.8.4",


Is that possibly dangerous deps update?

It should be ok (v0.8.4 contains fix for CVE-2022-39353), however the last one for 0.8.x is 0.8.7 (https://github.com/xmldom/xmldom/releases/tag/0.8.7).

I updated the version to 0.8.7 now

KonstantinTyukalov · 2023-04-12T15:34:48Z

/azp run

azure-pipelines · 2023-04-12T15:35:12Z

Azure Pipelines successfully started running 4 pipeline(s).

KonstantinTyukalov · 2023-04-12T15:41:58Z

@yitaopan please don't forget to bump the task version, otherwise your changes may be missing until the next task changes.
Once you do, just ping me again and I'll merge this

yitaopan · 2023-04-13T02:21:31Z

@KonstantinTyukalov I bumped the task version and updated the @xmldom/xmldom to the latest of 0.8.x, can you please take a look again? Thanks

KonstantinTyukalov · 2023-04-13T07:20:11Z

/azp run

azure-pipelines · 2023-04-13T07:20:33Z

Azure Pipelines successfully started running 4 pipeline(s).

KonstantinTyukalov · 2023-04-13T08:39:36Z

/azp run

azure-pipelines · 2023-04-13T08:39:55Z

Azure Pipelines successfully started running 4 pipeline(s).

yitaopan added 2 commits December 13, 2022 14:31

Rename to AzureSpringApps and a small bug fix

af3cb7f

Bump task version

ba2b943

bowen5 requested changes Dec 14, 2022

View reviewed changes

yitaopan added 2 commits December 15, 2022 16:33

Change back unused change

befa521

Rename code to AzureSpringApps

c6d616e

bowen5 requested changes Jan 4, 2023

View reviewed changes

yitaopan added 2 commits January 4, 2023 22:15

Merge main

282909f

Rename files

44e7eca

bowen5 approved these changes Jan 5, 2023

View reviewed changes

Update task version

08ab4a4

bowen5 approved these changes Jan 6, 2023

View reviewed changes

kirill-ivlev reviewed Feb 6, 2023

View reviewed changes

Tasks/AzureSpringCloudV0/operations/taskparameters.ts Show resolved Hide resolved

Merge master, resolve conflicts

e3587ba

kirill-ivlev approved these changes Feb 28, 2023

View reviewed changes

yitaopan and others added 5 commits March 9, 2023 09:54

Merge branch 'master' into yitaopan/asa_renaming

63b7fcc

Merge branch 'master' into yitaopan/asa_renaming

6592069

Merge branch 'master' into yitaopan/asa_renaming

01492bf

Merge branch 'master' into yitaopan/asa_renaming

429bc46

Upgrade xmldom

db3a488

vmapetr approved these changes Mar 30, 2023

View reviewed changes

Merge branch 'master' into yitaopan/asa_renaming

d5a0cf3

mmrazik approved these changes Apr 3, 2023

View reviewed changes

yitaopan and others added 3 commits April 12, 2023 12:33

Merge branch 'master' into yitaopan/asa_renaming

e41c8e2

Merge branch 'master' into yitaopan/asa_renaming

ebb8fd8

Update

26d4dfb

KonstantinTyukalov approved these changes Apr 12, 2023

View reviewed changes

yitaopan added 2 commits April 13, 2023 10:00

Bump task version && update xmldom version

7bd1e38

Rebuild task

198f667

Merge branch 'master' into yitaopan/asa_renaming

3b10e0c

Merge branch 'master' into yitaopan/asa_renaming

313c364

KonstantinTyukalov merged commit 29c22dd into microsoft:master Apr 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename to AzureSpringApps #17471

Rename to AzureSpringApps #17471

yitaopan commented Dec 13, 2022

bowen5 Dec 14, 2022

bowen5 Dec 14, 2022

yitaopan Dec 15, 2022

bowen5 Jan 4, 2023

yitaopan Jan 4, 2023 •

edited

Loading

bowen5 Jan 4, 2023

bowen5 Jan 4, 2023

yitaopan Jan 4, 2023

bowen5 Jan 4, 2023

bowen5 commented Jan 5, 2023

mmrazik commented Apr 3, 2023

azure-pipelines bot commented Apr 3, 2023

bowen5 commented Apr 6, 2023

KonstantinTyukalov commented Apr 10, 2023

yitaopan commented Apr 12, 2023

KonstantinTyukalov left a comment

KonstantinTyukalov Apr 12, 2023

yitaopan Apr 13, 2023

KonstantinTyukalov Apr 12, 2023

wolfwhitee Apr 12, 2023

yitaopan Apr 13, 2023

KonstantinTyukalov commented Apr 12, 2023

azure-pipelines bot commented Apr 12, 2023

KonstantinTyukalov commented Apr 12, 2023

yitaopan commented Apr 13, 2023

KonstantinTyukalov commented Apr 13, 2023

azure-pipelines bot commented Apr 13, 2023

KonstantinTyukalov commented Apr 13, 2023

azure-pipelines bot commented Apr 13, 2023

Rename to AzureSpringApps #17471

Rename to AzureSpringApps #17471

Conversation

yitaopan commented Dec 13, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yitaopan Jan 4, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bowen5 commented Jan 5, 2023

mmrazik commented Apr 3, 2023

azure-pipelines bot commented Apr 3, 2023

bowen5 commented Apr 6, 2023

KonstantinTyukalov commented Apr 10, 2023

yitaopan commented Apr 12, 2023

KonstantinTyukalov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KonstantinTyukalov commented Apr 12, 2023

azure-pipelines bot commented Apr 12, 2023

KonstantinTyukalov commented Apr 12, 2023

yitaopan commented Apr 13, 2023

KonstantinTyukalov commented Apr 13, 2023

azure-pipelines bot commented Apr 13, 2023

KonstantinTyukalov commented Apr 13, 2023

azure-pipelines bot commented Apr 13, 2023

yitaopan Jan 4, 2023 •

edited

Loading