Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support vs2022 in VsTestV2 #17460

Closed
wants to merge 1 commit into from

Conversation

galakt
Copy link
Member

@galakt galakt commented Dec 11, 2022

Task name: VsTestV2
Description: Support vs2022

Documentation changes required: Y

Added unit tests: N

Attached related issue: Y Fixes #16489 #15522

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@galakt
Copy link
Member Author

galakt commented Dec 12, 2022

@ShreyasRmsft @v-pkoneti @ankit-arora12 @nadesu pinging everyone because I am not sure who is the owner of this area

@rasunkar
Copy link

@abhadauria1 @Eswarnath Prudhivi, can you please look into this?

@rasunkar rasunkar self-requested a review December 15, 2022 14:20
@rasunkar
Copy link

@galakt , Can you please add more details around testing that was performed along with results from your dev testing?

@galakt
Copy link
Member Author

galakt commented Dec 15, 2022

@rasunkar That is actually another my question: how do you test this tasks?

@galakt
Copy link
Member Author

galakt commented Dec 15, 2022

You also have hack for version 16

// Temporary hack for 16.0. All this code will be removed once we migrate to the Hydra flow
if (testConfig.vsTestVersion === '16.0') {
testConfig.vsTestVersionDetails = new version.VSTestVersion(vstestexeLocation, 16, 0, 0);
return;
}

Is this hack still required? Should same hack be done for version 17?

@RandyDanielson
Copy link

Will this change fix the following error I see when I updated my tests to .NET 7?

2023-01-17T08:33:59.7770277Z ##[error]Testhost process for source(s) 'D:\a\r1\a\Drop\drop\FunctionalTests\Lectionary.Tests.dll' exited with error: You must install or update .NET to run this application.
2023-01-17T08:33:59.7782810Z ##[error]App: D:\a\r1\a\Drop\drop\FunctionalTests\testhost.dll
2023-01-17T08:33:59.7787883Z ##[error]Architecture: x64
2023-01-17T08:33:59.7795671Z ##[error]Framework: 'Microsoft.NETCore.App', version '7.0.0' (x64)
2023-01-17T08:33:59.7799130Z ##[error].NET location: C:\Program Files\dotnet\
2023-01-17T08:33:59.7803703Z ##[error]The following frameworks were found:
2023-01-17T08:33:59.7810122Z ##[error]  3.1.4 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
2023-01-17T08:33:59.7814265Z ##[error]  3.1.6 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
2023-01-17T08:33:59.7818220Z ##[error]  3.1.20 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
2023-01-17T08:33:59.7821337Z ##[error]  3.1.32 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
2023-01-17T08:33:59.7823695Z ##[error]  5.0.4 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
2023-01-17T08:33:59.7825639Z ##[error]  5.0.9 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
2023-01-17T08:33:59.7828677Z ##[error]  5.0.17 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
2023-01-17T08:33:59.7837214Z ##[error]  6.0.5 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
2023-01-17T08:33:59.7900586Z ##[error]  6.0.12 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
2023-01-17T08:33:59.7902493Z ##[error]Learn about framework resolution:
2023-01-17T08:33:59.7904448Z ##[error]https://aka.ms/dotnet/app-launch-failed
2023-01-17T08:33:59.7906407Z ##[error]To install missing framework, download:
2023-01-17T08:33:59.7908714Z ##[error]https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=7.0.0&arch=x64&rid=win10-x64
2023-01-17T08:33:59.7911026Z ##[error]. Please check the diagnostic logs for more information.

@galakt
Copy link
Member Author

galakt commented Mar 3, 2023

@RandyDanielson No, you updated tests to .net7, but net7 is not present at the moment of test execution

@galakt
Copy link
Member Author

galakt commented Mar 3, 2023

Changes will be ported to #17858

@galakt
Copy link
Member Author

galakt commented Mar 17, 2023

Resolved in #17858

@galakt galakt closed this Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VSTest@2 - Visual Studio 2022 not supported when explicit version is requested
3 participants