Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade GitHubReleaseV1 to NodeJS16 #17248

Merged
merged 3 commits into from
Jan 16, 2023
Merged

Upgrade GitHubReleaseV1 to NodeJS16 #17248

merged 3 commits into from
Jan 16, 2023

Conversation

Pranshu-Negi
Copy link
Contributor

Task name: GitHubReleaseV1

Description:

  • bumped task version
  • add node16 handler

Documentation changes required: N

Added unit tests: N

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@Pranshu-Negi Pranshu-Negi marked this pull request as ready for review November 21, 2022 14:40
@Pranshu-Negi
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@Pranshu-Negi Pranshu-Negi force-pushed the users/pranshunegi/GithubReleaseV1 branch from 8cace83 to 31ef9be Compare January 12, 2023 08:24
v-schhabra
v-schhabra reviewed Jan 12, 2023
View reviewed changes
Copy link
Contributor

@v-schhabra v-schhabra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and tested

@jmyersmsft jmyersmsft removed the request for review from a team January 12, 2023 14:56
v-nagarajku
v-nagarajku approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@v-nagarajku v-nagarajku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@v-nagarajku
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@v-nagarajku v-nagarajku merged commit 6075178 into microsoft:master Jan 16, 2023
@v-mohithgc v-mohithgc mentioned this pull request Feb 1, 2023
Merged
2 tasks
@max-zaytsev max-zaytsev mentioned this pull request Feb 7, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-schhabra v-schhabra v-schhabra left review comments

@v-nagarajku v-nagarajku v-nagarajku approved these changes

@rvairavelu rvairavelu rvairavelu approved these changes

@rohit-batra rohit-batra Awaiting requested review from rohit-batra

@carl-tanner carl-tanner Awaiting requested review from carl-tanner

@fadnavistanmay fadnavistanmay Awaiting requested review from fadnavistanmay

@b-barthel b-barthel Awaiting requested review from b-barthel

@manolerazvan manolerazvan Awaiting requested review from manolerazvan manolerazvan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Pranshu-Negi @v-nagarajku @rvairavelu @v-schhabra