Tasks Updates - G1 - Common (npm) - MSAL #17225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-tasks into users/ozanaydin/common-package-upgrade-2006423
ghost
requested a review
from 
ghost
changed the title
starkmsu
approved these changes
Nov 17, 2022
z00sts
approved these changes
Nov 17, 2022
…-tasks into users/ozanaydin/common-package-upgrade-2006423
|
|
…-tasks into users/ozanaydin/common-package-upgrade-2006423
rohit-batra
reviewed
Nov 21, 2022
|
Hi @ozanovus @z00sts @starkmsu @rohit-batra, looks like this PR hasn't gone thru manual functionality testing. I tested the changes made in this PR and I can see many warnings. Can you please revert the changes made to azure key vault task in this PR, before it's rolled out to production. |
|
I've connected with @v-mohithgc , we're investigating the warnings. |
|
New PR is created for bugfix. (tested on my side) |
2 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: AzureKeyVaultV1, AzureKeyVaultV2, AzureResourceManagerTemplateDeploymentV3, AzureAppServiceManageV0
Description: Updated package dependencies for common npm package (MSAL upgrade)
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N
Attached related issue: (Y/N) N
Checklist: