Upgrading GoToolV0 task to NodeJS 16 #17150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roman-Shchukin
requested review from
rohit-batra,
thewulf7 and
lucen-ms
as code owners
|
Task was tested on macos-latest, windows-latest and ubuntu-latest images with node10 and node16 handlers |
Roman-Shchukin
changed the title
|
Hi @Roman-Shchukin, is it good to be merged? Do we need to perform any functionality testing? |
Hi @v-mohithgc, I think it can be merged |
|
approved |
PhilipsonJoseph
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: GoToolV0
Description: Task was upgraded to NodeJS 16
Documentation changes required: N
Added unit tests: N
Attached related issue: https://github.com/microsoft/build-task-team/issues/3711
Checklist: