Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vulnerability fix for AzureKeyVaultV1 #17138

Merged
merged 7 commits into from
Dec 1, 2022
Merged

Vulnerability fix for AzureKeyVaultV1 #17138

merged 7 commits into from
Dec 1, 2022

Conversation

Pranshu-Negi
Copy link
Contributor

Task name: AzureKeyVaultV1

Description:

Documentation changes required: (Y/N)

Added unit tests: (Y/N)

Attached related issue: (Y/N) https://dev.azure.com/mseng/PipelineTools/_componentGovernance/184/alert/79428?typeId=12858

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected
  • node make.js build --task AzureKeyVaultV1
  • node make.js test --task AzureKeyVaultV1

@Pranshu-Negi
Copy link
Contributor Author

@microsoft-github-policy-service agree [company="Microsoft"]

@Pranshu-Negi
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@Pranshu-Negi Pranshu-Negi marked this pull request as ready for review November 8, 2022 16:20
@PavloAndriiesh
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@PavloAndriiesh
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@Pranshu-Negi Pranshu-Negi force-pushed the users/pranshunegi/AzureKeyVaultV1 branch from 3c553e4 to 24fbefd Compare November 9, 2022 08:42
@PavloAndriiesh
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

v-mohithgc
v-mohithgc approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@v-mohithgc v-mohithgc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and validated.

@microsoft microsoft deleted a comment from azure-pipelines bot Nov 30, 2022
@v-nagarajku
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@v-nagarajku v-nagarajku merged commit db56468 into microsoft:master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-mohithgc v-mohithgc v-mohithgc approved these changes

@PavloAndriiesh PavloAndriiesh PavloAndriiesh approved these changes

@rohit-batra rohit-batra Awaiting requested review from rohit-batra

@manolerazvan manolerazvan Awaiting requested review from manolerazvan manolerazvan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Pranshu-Negi @PavloAndriiesh @v-nagarajku @v-mohithgc