Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability fix for DuffleInstallerV0 #17115

Merged

Conversation

v-schhabra
Copy link
Contributor

@v-schhabra v-schhabra commented Nov 1, 2022

Task name: DuffleInstallerV0

Description:

Documentation changes required: (Y/N)

Added unit tests: (Y/N)

Attached related issue: (Y/N) https://dev.azure.com/mseng/PipelineTools/_componentGovernance/184/alert/79428?typeId=12858
Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected
  • node make.js build --task DuffleInstallerV0
  • node make.js test --task DuffleInstallerV0

Copy link
Contributor

@v-mohithgc v-mohithgc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@rvairavelu rvairavelu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@rohit-batra
Copy link
Contributor

I am assuming added dependencies in package lock file have been verified, right ? if not please do it once ,

@v-schhabra
Copy link
Contributor Author

Yes, @rohit-batra dependencies in package lock file are verified.

@v-nagarajku
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@v-nagarajku
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@v-nagarajku v-nagarajku merged commit 4d56fa2 into microsoft:master Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants