Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove broken test from ARMTD task #16992

Merged
merged 1 commit into from
Sep 30, 2022
Merged

remove broken test from ARMTD task #16992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions Tasks/AzureResourceManagerTemplateDeploymentV3/Tests/L0.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,22 +213,22 @@ describe('Azure Resource Manager Template Deployment', function () {
}
});

it('createOrUpdate deployment should fail when bicep file contains error', (done) => {
let tp = path.join(__dirname, 'createOrUpdate.js');
process.env["csmFile"] = "CSMwithBicepWithError.bicep";
process.env["csmParametersFile"] = "";
let tr = new ttm.MockTestRunner(tp);
tr.run();
try {
assert(!tr.succeeded, "Should have failed");
assert(tr.stdout.indexOf("This declaration type is not recognized. Specify a parameter, variable, resource, or output declaration.") > 0, "should have printed the error message")
assert(tr.stdout.indexOf("deployments.createOrUpdate is called") < 0, "deployments.createOrUpdate function should not have been called from azure-sdk");
done();
}
catch (error) {
console.log("STDERR", tr.stderr);
console.log("STDOUT", tr.stdout);
done(error);
}
});
// it('createOrUpdate deployment should fail when bicep file contains error', (done) => {
// let tp = path.join(__dirname, 'createOrUpdate.js');
// process.env["csmFile"] = "CSMwithBicepWithError.bicep";
// process.env["csmParametersFile"] = "";
// let tr = new ttm.MockTestRunner(tp);
// tr.run();
// try {
// assert(!tr.succeeded, "Should have failed");
// assert(tr.stdout.indexOf("This declaration type is not recognized. Specify a parameter, variable, resource, or output declaration.") > 0, "should have printed the error message")
// assert(tr.stdout.indexOf("deployments.createOrUpdate is called") < 0, "deployments.createOrUpdate function should not have been called from azure-sdk");
// done();
// }
// catch (error) {
// console.log("STDERR", tr.stderr);
// console.log("STDOUT", tr.stdout);
// done(error);
// }
// });
});
2 changes: 1 addition & 1 deletion Tasks/AzureResourceManagerTemplateDeploymentV3/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"version": {
"Major": 3,
"Minor": 210,
"Patch": 0
"Patch": 1
},
"demands": [],
"minimumAgentVersion": "2.119.1",
Expand Down
2 changes: 1 addition & 1 deletion Tasks/AzureResourceManagerTemplateDeploymentV3/task.loc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"version": {
"Major": 3,
"Minor": 210,
"Patch": 0
"Patch": 1
},
"demands": [],
"minimumAgentVersion": "2.119.1",
Expand Down