Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Cosmetic API calls #16868

Merged
merged 4 commits into from
Oct 3, 2022
Merged

Fix for Cosmetic API calls #16868

merged 4 commits into from
Oct 3, 2022

Conversation

v-nagarajku
Copy link
Contributor

Task name: AzureRmWebAppDeploymentV4

Description: Fix for cosmetic API calls.

Documentation changes required: N

Added unit tests: N

Attached related issue: N

Checklist:

  • [ X] Task version was bumped - please check instruction how to do it
  • [ X] Checked that applied changes work as expected

@v-nagarajku v-nagarajku requested review from a user, mmrazik and PhilipsonJoseph September 12, 2022 12:44
ghost
ghost suggested changes Oct 3, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you forgot some debug logs for development?

Tasks/AzureRmWebAppDeploymentV4/deploymentProvider/BuiltInLinuxWebAppDeploymentProvider.ts Outdated Show resolved Hide resolved
Tasks/AzureRmWebAppDeploymentV4/deploymentProvider/BuiltInLinuxWebAppDeploymentProvider.ts Outdated Show resolved Hide resolved
Tasks/AzureRmWebAppDeploymentV4/deploymentProvider/WindowsWebAppRunFromZipProvider.ts Outdated Show resolved Hide resolved
ghost
ghost approved these changes Oct 3, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your effort, looks good to me!

@v-nagarajku
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@v-nagarajku v-nagarajku merged commit b82a8e6 into master Oct 3, 2022
@ghost
Copy link

ghost commented Oct 3, 2022

Let's not forget to delete branch.
Estimated date: 21 October 2022
@v-nagarajku

@ghost ghost mentioned this pull request Dec 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmrazik mmrazik Awaiting requested review from mmrazik

@PhilipsonJoseph PhilipsonJoseph Awaiting requested review from PhilipsonJoseph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v-nagarajku @nagarajku