Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow installing Node.js version based on file #16835

Merged
merged 11 commits into from
Sep 12, 2022

Conversation

ismayilov-ismayil
Copy link
Contributor

@ismayilov-ismayil ismayilov-ismayil commented Sep 2, 2022

Task name: Allow installing Node.js version based on .nvmrc

Description: Currently we have only option to specify Node version during pipeline creation. We add new option to get version from .nvmrc file

Before

After

Documentation changes required: (Y/N) Y

Added unit tests: (Y/N) Y

Attached related issue: (Y/N) Y
#14094
Checklist:

  • Task version was bumped - v0.210.1
  • Checked that applied changes work as expected

@ismayilov-ismayil ismayilov-ismayil added the Area: ABTT Akvelon Build Tasks Team area of work label Sep 3, 2022
@ismayilov-ismayil ismayilov-ismayil changed the title Users/ismayilov ismayil/node ver from file Allow installing Node.js version based on file Sep 3, 2022
@ismayilov-ismayil ismayilov-ismayil marked this pull request as ready for review September 5, 2022 07:05
@ismayilov-ismayil ismayilov-ismayil requested a review from a team as a code owner September 5, 2022 07:05
@max-zaytsev max-zaytsev merged commit 068c5c7 into master Sep 12, 2022
ismayilov-ismayil added a commit that referenced this pull request Sep 22, 2022
* Added option to read Node version from file

* Added test for read version from file

* Added loc resources of new options

* Added new parameter to previous tests

* Task version was bumped

* Grammatical correction in loc resources

Co-authored-by: Maxim Zaytsev <v-mazayt@microsoft.com>

* Help message rephrased

* updated related files based on task.json

* NodeToolV0 task version was bumped

Co-authored-by: Maxim Zaytsev <v-mazayt@microsoft.com>
@atwright147
Copy link

Hey, I cannot see this option in my pipeline, how do I get to take advantage of this?

And how would I use this when writing in YAML?

Sorry for adding noise to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: ABTT Akvelon Build Tasks Team area of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants