-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow installing Node.js version based on file #16835
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismayilov-ismayil
changed the title
Users/ismayilov ismayil/node ver from file
Allow installing Node.js version based on file
Sep 3, 2022
vmapetr
approved these changes
Sep 5, 2022
DmitriiBobreshev
approved these changes
Sep 5, 2022
max-zaytsev
reviewed
Sep 5, 2022
Tasks/NodeToolV0/Strings/resources.resjson/en-US/resources.resjson
Outdated
Show resolved
Hide resolved
max-zaytsev
reviewed
Sep 5, 2022
Tasks/NodeToolV0/Strings/resources.resjson/en-US/resources.resjson
Outdated
Show resolved
Hide resolved
Co-authored-by: Maxim Zaytsev <v-mazayt@microsoft.com>
kirill-ivlev
approved these changes
Sep 6, 2022
max-zaytsev
approved these changes
Sep 6, 2022
wojgasior
approved these changes
Sep 8, 2022
TomasHubelbauer
pushed a commit
that referenced
this pull request
Sep 12, 2022
ismayilov-ismayil
added a commit
that referenced
this pull request
Sep 22, 2022
* Added option to read Node version from file * Added test for read version from file * Added loc resources of new options * Added new parameter to previous tests * Task version was bumped * Grammatical correction in loc resources Co-authored-by: Maxim Zaytsev <v-mazayt@microsoft.com> * Help message rephrased * updated related files based on task.json * NodeToolV0 task version was bumped Co-authored-by: Maxim Zaytsev <v-mazayt@microsoft.com>
Hey, I cannot see this option in my pipeline, how do I get to take advantage of this? And how would I use this when writing in YAML? Sorry for adding noise to this PR |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: Allow installing Node.js version based on .nvmrc
Description: Currently we have only option to specify Node version during pipeline creation. We add new option to get version from .nvmrc file
Before
After
Documentation changes required: (Y/N) Y
Added unit tests: (Y/N) Y
Attached related issue: (Y/N) Y
#14094
Checklist: