Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NPM package definition from tests of JenkinsQueueJobV2 #16668

Conversation

KonstantinTyukalov
Copy link
Contributor

@KonstantinTyukalov KonstantinTyukalov commented Jul 29, 2022

Task name: JenkinsQueueJobV2

Description: Remove NPM package definition from tests because it is not used, may contain version conflicts between main task packages, and contains several vulnerabilities:

Plus this PS resolves on moderate vulnerability in task itself - GHSA-hj48-42vr-x3v9

Changelog:

  • Removed npm package definition from tests (package*.json)
  • Removed unused imports in tests
  • Added scripts to build and test task
  • Resolved task vulnerability
  • Bumped task version

Documentation changes required: N

Added unit tests: N

Attached related issue: N

Checklist:

  • Task version was bumped - instruction
  • Checked that applied changes work as expected - ran unit tests locally

Risks analysis checklist:

  • There are no risky dependency updates
  • Changes have been tested
  • Enough test coverage for changes and current test coverage for the task doesn't look poor
  • We understand how the task is working, how changes affect the task behavior
  • There are no breaking changes
  • There are no other concerns
  • I have not discovered any new uncovered test/use cases

@KonstantinTyukalov KonstantinTyukalov requested a review from a team as a code owner July 29, 2022 08:49
@KonstantinTyukalov KonstantinTyukalov self-assigned this Jul 30, 2022
@KonstantinTyukalov KonstantinTyukalov merged commit 21e1ac3 into master Aug 3, 2022
@KonstantinTyukalov KonstantinTyukalov deleted the users/KonstantinTyukalov/JenkinsQueueJobV2_tests_rm_npm_package branch April 16, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants