-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GHSA-h726-x36v-rx45 #16485
Merged
tintse-thxsky-MSFT
merged 12 commits into
microsoft:master
from
tintse-thxsky-MSFT:Microsoft/user/tintse/lodash
Jul 19, 2022
Merged
Fix GHSA-h726-x36v-rx45 #16485
tintse-thxsky-MSFT
merged 12 commits into
microsoft:master
from
tintse-thxsky-MSFT:Microsoft/user/tintse/lodash
Jul 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tintse-thxsky-MSFT
requested review from
phil-hodgson,
aasim and
satbai
as code owners
June 23, 2022 20:47
Make sure you bump the version of the tasks that use packaging-common |
tintse-thxsky-MSFT
requested review from
a team,
rohit-batra and
v-nmursapall
as code owners
July 12, 2022 19:15
/azp |
Supported commands
See additional documentation. |
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
satbai
reviewed
Jul 13, 2022
satbai
reviewed
Jul 13, 2022
satbai
approved these changes
Jul 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
tintse-thxsky-MSFT
removed request for
a team,
aasim,
phil-hodgson,
rohit-batra and
v-nmursapall
July 19, 2022 00:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: Tasks/Common/packaging-common/package.json
Description: Fix GHSA-h726-x36v-rx45. Since the root dependency that uses lodash, ip-address, is no longer being used anywhere in packaging-common, I decided to remove "ip-address" from package.json
Documentation changes required: N
Added unit tests: N
Attached related issue: GHSA-h726-x36v-rx45
Checklist: