Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vulnerabilities (#3072) in UseNodeV1 task #16452

Merged
merged 14 commits into from
Jul 12, 2022
Merged

Fix vulnerabilities (#3072) in UseNodeV1 task #16452

merged 14 commits into from
Jul 12, 2022

Conversation

kirill-ivlev
Copy link
Contributor

Task name: UseNodeV1

Description: update vulnerable packages with npm audit fix, update package dependencies, update unit test to correspond latest changes in task-lib

Documentation changes required: (Y/N) N

Added unit tests: (Y/N) N

Attached related issue: (Y/N) https://github.com/microsoft/build-task-team/issues/3072

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@kirill-ivlev kirill-ivlev requested a review from a team as a code owner June 15, 2022 06:16
@kirill-ivlev kirill-ivlev changed the title Fix vulnerabilities (#3072) Fix vulnerabilities (#3072) in UseNodeV1 task Jun 17, 2022
@alexander-smolyakov
Copy link
Contributor

alexander-smolyakov commented Jun 20, 2022

/apz run

Copy link
Contributor

@alexander-smolyakov alexander-smolyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you please ask someone from the team to perform buddy-testing? And please post the results of the risks analysis checklist.

@DmitriiBobreshev
Copy link
Contributor

DmitriiBobreshev commented Jun 22, 2022

performed buddy testing:
Unit Testing Result: all tests passed, file: UseNodeV1TestsOut.txt
Pipeline Tests on win and Linux machines, tests passed, logs: UseNodeV1TestsPipeline.zip

@kirill-ivlev kirill-ivlev merged commit 3cd30c5 into microsoft:master Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants