Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate NuGetToolInstallerV1 task to Node10 #15824

Merged
merged 9 commits into from
Jul 28, 2022
Merged

Migrate NuGetToolInstallerV1 task to Node10 #15824

merged 9 commits into from
Jul 28, 2022

Conversation

mr-dokara
Copy link
Contributor

Task name: NuGetToolInstallerV1

Description: Migrated task to Node10

Documentation changes required: N

Added unit tests: N

Attached related issue: N

Checklist:

  • Task version was bumped
  • Checked that applied changes work as expected

@mr-dokara mr-dokara mentioned this pull request Jan 25, 2022
Closed
39 tasks
@mr-dokara mr-dokara requested a review from a team January 25, 2022 12:25
@mr-dokara
Copy link
Contributor Author

cc @geekzter for visibility

@mr-dokara mr-dokara requested a review from mmrazik February 25, 2022 09:06
@mr-dokara
Copy link
Contributor Author

Hi @aasim, @phil-hodgson, Could you please take a look at this PR?

@mr-dokara mr-dokara requested a review from satbai as a code owner June 30, 2022 15:37
@DmitriiBobreshev
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@DmitriiBobreshev
Copy link
Contributor

Test results are here

Risks analysis checklist

  • There are no risky dependency updates
  • Changes have been tested
  • Enough test coverage for changes and current test coverage for the task doesn't look poor
  • We understand how tasks are working, how changes affect task behavior
  • There are no breaking changes
  • There are no other concerns
  • I have not discovered any new uncovered test/use cases

@DmitriiBobreshev
Copy link
Contributor

DmitriiBobreshev commented Jul 6, 2022 •
edited
Loading

Hi @phil-hodgson, @aasim, @satbai Could you please take a look at this PR?

@mpodriezov
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@mpodriezov
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@tintse-thxsky-MSFT
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@tintse-thxsky-MSFT tintse-thxsky-MSFT merged commit 6cf677e into master Jul 28, 2022
@KonstantinTyukalov KonstantinTyukalov mentioned this pull request Aug 22, 2022
Closed
@tintse-thxsky-MSFT tintse-thxsky-MSFT deleted the users/golubev-ivan/migrate-nuget-tool-installer-v1-to-node10 branch October 24, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tintse-thxsky-MSFT tintse-thxsky-MSFT tintse-thxsky-MSFT approved these changes

@kirill-ivlev kirill-ivlev kirill-ivlev approved these changes

@vmapetr vmapetr vmapetr approved these changes

@EzzhevNikita EzzhevNikita EzzhevNikita approved these changes

@anatolybolshakov anatolybolshakov anatolybolshakov approved these changes

@aasim aasim Awaiting requested review from aasim

@phil-hodgson phil-hodgson Awaiting requested review from phil-hodgson

@mmrazik mmrazik Awaiting requested review from mmrazik

@satbai satbai Awaiting requested review from satbai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mr-dokara @DmitriiBobreshev @mpodriezov @tintse-thxsky-MSFT @anatolybolshakov @EzzhevNikita @vmapetr @kirill-ivlev