Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new input to disable partition_id set up #15570

Conversation

anatolybolshakov
Copy link
Contributor

@anatolybolshakov anatolybolshakov commented Dec 2, 2021

Task name: InstallAppleCertificateV2

Description: added setUpPartitionIdACLForPrivateKey input - to be able to disable partition_id ACL setting up - since it's not necessary sometimes and could cause issues.

Documentation changes required: Y

Added unit tests: Y

Attached related issue: #10792

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected - tested with updated common package - checked that partition_id set up is properly disabled by new input

@anatolybolshakov anatolybolshakov requested a review from a team December 2, 2021 17:37
@anatolybolshakov anatolybolshakov force-pushed the users/anatolybolshakov/fix_InstallCertificate_several_certificates branch from d6a9cf6 to 5a238b1 Compare December 2, 2021 19:30
@EzzhevNikita EzzhevNikita requested a review from a team December 7, 2021 11:37
Copy link
Contributor

@alexander-smolyakov alexander-smolyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and please take a look at the suggestions below.

Tasks/InstallAppleCertificateV2/preinstallcert.ts Outdated Show resolved Hide resolved
Tasks/InstallAppleCertificateV2/preinstallcert.ts Outdated Show resolved Hide resolved
Anatoly Bolshakov and others added 6 commits December 9, 2021 12:27
Co-authored-by: Alexander Smolyakov <v-alsmo@microsoft.com>
Co-authored-by: Alexander Smolyakov <v-alsmo@microsoft.com>
…ertificates' of https://github.com/microsoft/azure-pipelines-tasks into users/anatolybolshakov/fix_InstallCertificate_several_certificates
@EzzhevNikita EzzhevNikita self-requested a review December 10, 2021 14:06
@anatolybolshakov anatolybolshakov merged commit 30803ec into master Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants