[AppCenterDistributeV1] Update the Nock package dependency #15371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenisRumyantsev
changed the title
DenisRumyantsev
changed the title
max-zaytsev
approved these changes
Oct 6, 2021
EzzhevNikita
approved these changes
Oct 8, 2021
alexander-smolyakov
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: AppCenterDistributeV1
Description:
We need to update the
nockpackage dependency for theAppCenterDistributeV1task to fix thelodashdependabot alert.Nock version was updated from
9.0.2to10.0.6.Lodash version was automatically updated from
4.9.0to4.17.21(currently latest).There are breaking changes between
10.0.6and11.3.2. You can see breaking changes in the release notes.So we have to use the
10.0.6Nock version.Documentation changes required: (Y/N)
Added unit tests: (Y/N)
Attached related issue: (Y/N)
Checklist:
AppCenterDistributeV1 task with the updated
nockpackage dependency was successfully built, deployed to the Azure DevOps organization, and added to a pipeline. I did not run this pipeline since this task requires creating an application and App Center service connection as server endpoint input. It is enough for testing since the updated dependency is related to unit-tests which work correctly with the10.0.6Nock version.