Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed and added unit tests for JavaToolInstallerV0 task #15355

Merged

Conversation

AnnaOpareva
Copy link
Contributor

Task name: JavaToolInstallerV0

Description: Fixed unit test for fetching JDK files from Azure storage, added unit test for fetching JDK files from azure storage from subfolder

Documentation changes required: (Y/N) N

Added unit tests: (Y/N) Y

Attached related issue: (Y/N) N

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@AnnaOpareva AnnaOpareva requested a review from a team as a code owner September 30, 2021 09:31
Tasks/JavaToolInstallerV0/Tests/L0.ts Outdated Show resolved Hide resolved
Tasks/JavaToolInstallerV0/javatoolinstaller.ts Outdated Show resolved Hide resolved
Tasks/JavaToolInstallerV0/task.json Outdated Show resolved Hide resolved
@EzzhevNikita EzzhevNikita requested a review from a team September 30, 2021 10:45
Copy link
Contributor

@anatolybolshakov anatolybolshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@AnnaOpareva
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@AnnaOpareva AnnaOpareva merged commit f28252c into master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants