[BashV3] Add task input to provide an ability to set BASH_ENV environment variable
#15352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 29, 2021 16:04
- Remove `noRc` and `noProfile` inputs from task UI - Remove ` --noprofile` and `--norc` arguments from `translateDirectoryPath` function - Remove `--noprofile` and `--norc` arguments from unit tests mocked answers
- Add `bashEnvValue` input for task UI - Add `setBashEnvVariable` function
- Updated help markdown of `bashEnvValue` input - Updated help description `setBashEnvVariable` function - Minor code changes
…_remove_norc_noprofile_inputs
EzzhevNikita
approved these changes
Oct 8, 2021
|
LGTM! |
added 4 commits
October 8, 2021 20:17
- Added `BASH_ENV - set environment variable` unit test - Added `BASH_ENV - override environment variable` unit test
…_remove_norc_noprofile_inputs
max-zaytsev
approved these changes
Oct 12, 2021
…_remove_norc_noprofile_inputs
…_remove_norc_noprofile_inputs
anatolybolshakov
approved these changes
Oct 12, 2021
alexander-smolyakov
deleted the
users/alexander-smolyakov/issue1641_BashV3_remove_norc_noprofile_inputs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name:
Issue description:
Since the Bash pipeline task invokes Bash as a non-interactive shell
noRcandnoProfileinputs are ignored by the Bash according to the documentation. In the non-interactive mode, Bash looks only for theBASH_ENVenvironment variable.Fix:
This PR introduces a new input for the Bash task to provide an ability to set a value for
BASH_ENVenvironment variable. The customer could set a path to the startup file In this environment variable that will be read before script execution.Changes:
noRcandnoProfileinputs are removed from the taskbashEnvValueto provide an ability to setBASH_ENVenvironment variable for the taskDocumentation changes required: Yes
Added unit tests: Yes
Attached related issue:
Checklist: