Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14091 Inline scripts not working in v5 with space in the filename #14091 #15275

Merged
merged 6 commits into from
Oct 19, 2021

Conversation

PhilipsonJoseph
Copy link
Contributor

@PhilipsonJoseph PhilipsonJoseph commented Sep 13, 2021

Task name: AzurePowerShellV4, AzurePowerShellV5

Description: When the private agent has an space in Folder the Execution got failed. As a fix added a double Quote to the path

Documentation changes required: (Y/N) N

Added unit tests: (Y/N) N

Attached related issue: (Y/N) N

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@PhilipsonJoseph PhilipsonJoseph changed the title 14091 Inline scripts not working in v5 with space in the filename #14091 AzureFunctionAppContainer@1 sets WEBSITES_ENABLE_APP_SERVICE_STORAGE to false even if user provides 'appSettings: -WEBSITES_ENABLE_APP_SERVICE_STORAGE true' #14857 Sep 13, 2021
@PhilipsonJoseph PhilipsonJoseph changed the title AzureFunctionAppContainer@1 sets WEBSITES_ENABLE_APP_SERVICE_STORAGE to false even if user provides 'appSettings: -WEBSITES_ENABLE_APP_SERVICE_STORAGE true' #14857 14091 Inline scripts not working in v5 with space in the filename #14091 Sep 13, 2021
@@ -93,7 +93,7 @@ try {
$contents += "`$VerbosePreference = 'continue'"
}

$contents += ". $PSScriptRoot\UpdatePSModulePath.ps1 $UpdatePSModulePathArgument"
$contents += ". `'$PSScriptRoot\UpdatePSModulePath.ps1`' $UpdatePSModulePathArgument"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in case of single quote also do we need escape chars ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chshrikh Not needed chaitanya. I removed the escape characters

@PhilipsonJoseph PhilipsonJoseph merged commit 82f880e into master Oct 19, 2021
@PhilipsonJoseph PhilipsonJoseph deleted the users/v-phiv/task_issue_fix_14091 branch October 19, 2021 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants