-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
14091 Inline scripts not working in v5 with space in the filename #14091 #15275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilipsonJoseph
changed the title
14091 Inline scripts not working in v5 with space in the filename #14091
AzureFunctionAppContainer@1 sets WEBSITES_ENABLE_APP_SERVICE_STORAGE to false even if user provides 'appSettings: -WEBSITES_ENABLE_APP_SERVICE_STORAGE true' #14857
Sep 13, 2021
PhilipsonJoseph
changed the title
AzureFunctionAppContainer@1 sets WEBSITES_ENABLE_APP_SERVICE_STORAGE to false even if user provides 'appSettings: -WEBSITES_ENABLE_APP_SERVICE_STORAGE true' #14857
14091 Inline scripts not working in v5 with space in the filename #14091
Sep 13, 2021
chshrikh
reviewed
Sep 22, 2021
chshrikh
reviewed
Sep 23, 2021
@@ -93,7 +93,7 @@ try { | |||
$contents += "`$VerbosePreference = 'continue'" | |||
} | |||
|
|||
$contents += ". $PSScriptRoot\UpdatePSModulePath.ps1 $UpdatePSModulePathArgument" | |||
$contents += ". `'$PSScriptRoot\UpdatePSModulePath.ps1`' $UpdatePSModulePathArgument" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in case of single quote also do we need escape chars ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chshrikh Not needed chaitanya. I removed the escape characters
chshrikh
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: AzurePowerShellV4, AzurePowerShellV5
Description: When the private agent has an space in Folder the Execution got failed. As a fix added a double Quote to the path
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N
Attached related issue: (Y/N) N
Checklist: